You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/05/03 10:48:06 UTC

[GitHub] [spark] pan3793 commented on a diff in pull request #41030: [SPARK-43352][K8S][TEST] Inline `DepsTestsSuite#setPythonSparkConfProperties`

pan3793 commented on code in PR #41030:
URL: https://github.com/apache/spark/pull/41030#discussion_r1183526759


##########
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala:
##########
@@ -371,7 +371,7 @@ private[spark] trait DepsTestsSuite { k8sSuite: KubernetesSuite =>
   }
 
   private def setPythonSparkConfProperties(conf: SparkAppConf): Unit = {

Review Comment:
   make sense, addressed, also updated PR title and description



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org