You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by Chand2048 <gi...@git.apache.org> on 2015/02/25 20:27:22 UTC

[GitHub] lucenenet pull request: Fix for TestThreadInterruptDeadlock

GitHub user Chand2048 opened a pull request:

    https://github.com/apache/lucenenet/pull/111

    Fix for TestThreadInterruptDeadlock

    Use the C# ThreadInterruptedException so the catches will properly control the flow during interruption.
    This fixes the two unit tests Lucene.Next.Index.TestIndexWriter.TestThreadInterruptDeadlock and Lucene.Next.Index.TestIndexWriter.TestTwoThreadsInterruptDeadlock
    Lucene uses the ThreadInterruptedException for code flow control so it is important to use the C# ThreadInterruptedException to avoid duplicating the catch everywhere and preserve the flow.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guidotag/lucenenet TestThreadInterruptDeadlock2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #111
    
----
commit 9769e6d5d1c35fc4f7095450bef24fd452caa53f
Author: Chand2048 <ch...@microsoft.com>
Date:   2015-02-25T19:26:29Z

    Fix for TestThreadInterruptDeadlock
    
    Use the C# ThreadInterruptedException so the catches will properly control the flow during interruption.
    This fixes the two unit tests Lucene.Next.Index.TestIndexWriter.TestThreadInterruptDeadlock and Lucene.Next.Index.TestIndexWriter.TestTwoThreadsInterruptDeadlock
    Lucene uses the ThreadInterruptedException for code flow control so it is important to use the C# ThreadInterruptedException to avoid duplicating the catch everywhere and preserve the flow.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request: Fix for TestThreadInterruptDeadlock

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/lucenenet/pull/111


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request: Fix for TestThreadInterruptDeadlock

Posted by Chand2048 <gi...@git.apache.org>.
Github user Chand2048 commented on the pull request:

    https://github.com/apache/lucenenet/pull/111#issuecomment-76036342
  
    This is the squashed and rebased version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---