You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/20 16:00:16 UTC
[GitHub] [kafka] dajac opened a new pull request #9462: MINOR; Fix UpdateMetadataRequestTest.testVersionLogic's assertions
dajac opened a new pull request #9462:
URL: https://github.com/apache/kafka/pull/9462
`UpdateMetadataRequestTest.testVersionLogic`'s assertions must verify the deserialized request.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #9462: MINOR; Fix UpdateMetadataRequestTest.testVersionLogic's assertions
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #9462:
URL: https://github.com/apache/kafka/pull/9462#issuecomment-712957528
@chia7712 Could you take a look at this one please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #9462: MINOR; Fix UpdateMetadataRequestTest.testVersionLogic's assertions
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #9462:
URL: https://github.com/apache/kafka/pull/9462#issuecomment-713085833
Test failures not related, merging to trunk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #9462: MINOR; Fix UpdateMetadataRequestTest.testVersionLogic's assertions
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #9462:
URL: https://github.com/apache/kafka/pull/9462#issuecomment-713070708
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #9462: MINOR; Fix UpdateMetadataRequestTest.testVersionLogic's assertions
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #9462:
URL: https://github.com/apache/kafka/pull/9462#issuecomment-713069657
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac merged pull request #9462: MINOR; Fix UpdateMetadataRequestTest.testVersionLogic's assertions
Posted by GitBox <gi...@apache.org>.
dajac merged pull request #9462:
URL: https://github.com/apache/kafka/pull/9462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org