You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by "z7658329 (via GitHub)" <gi...@apache.org> on 2023/02/11 10:01:31 UTC
[GitHub] [incubator-hugegraph-doc] z7658329 opened a new pull request, #197: feat/validate support mulit os
z7658329 opened a new pull request, #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197
validate release actions support mulit os
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-doc] github-actions[bot] commented on pull request #197: validate release actions support mulit os
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#issuecomment-1475397483
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-doc] javeme commented on a diff in pull request #197: validate release actions support mulit os
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on code in PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#discussion_r1105879056
##########
.github/workflows/validate-release.yml:
##########
@@ -212,8 +236,6 @@ jobs:
cd dist/${{ inputs.release_version }}
cd ./*hugegraph-incubating*${{ inputs.release_version }} || exit
bin/init-store.sh && sleep 1
- # kill the HugeGraphServer process by jps
- jps | grep HugeGraphServer | awk '{print $1}' | xargs kill -9
Review Comment:
we must stop the old one, otherwise can't start the new one
##########
.github/workflows/validate-release.yml:
##########
@@ -180,6 +182,7 @@ jobs:
echo "test hubble"
cd ./*hubble*${{ inputs.release_version }} || exit
cat conf/hugegraph-hubble.properties && bin/start-hubble.sh
+ # TODO: need stop the server here
Review Comment:
if it's difficult to find a time to stop, we can close the old one before starting server.
##########
.github/workflows/validate-release.yml:
##########
@@ -245,8 +267,12 @@ jobs:
cat conf/hugegraph-hubble.properties
bin/stop-hubble.sh && bin/start-hubble.sh
cd - || exit
+ # TODO: need stop the server here
+ jps | grep HugeGraphServer | awk '{print $1}' | xargs kill -9
Review Comment:
sleep a while before the stop, like 60s?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-doc] imbajin commented on a diff in pull request #197: validate release actions support mulit os
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#discussion_r1103645609
##########
.github/workflows/validate-release.yml:
##########
@@ -250,3 +270,4 @@ jobs:
fail-fast: false
matrix:
java_version: [ '8','11' ]
+ os: [ubuntu-latest, macos-latest] # TODO: support windows-latest or other os in future
Review Comment:
perfer not to use comment after the line（use a separate line）
and seems miss centos here？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-doc] javeme commented on a diff in pull request #197: validate release actions support mulit os
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on code in PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#discussion_r1103772325
##########
.github/workflows/validate-release.yml:
##########
@@ -250,3 +270,4 @@ jobs:
fail-fast: false
matrix:
java_version: [ '8','11' ]
+ os: [ubuntu-latest, macos-latest] # TODO: support windows-latest or other os in future
Review Comment:
seems github does not support CentOS, the supported runners: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
I think we can mark "TODO: support CentOS" now.
how to support CentOS: https://zhuanlan.zhihu.com/p/344367359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-doc] z7658329 commented on a diff in pull request #197: validate release actions support mulit os
Posted by "z7658329 (via GitHub)" <gi...@apache.org>.
z7658329 commented on code in PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#discussion_r1105131879
##########
.github/workflows/validate-release.yml:
##########
@@ -104,32 +108,41 @@ jobs:
if [[ ! -f "DISCLAIMER" ]]; then
echo "The package should include DISCLAIMER file" && exit 1
fi
+ # 4.2 ensure doesn't contains *GPL/BCL/JSR-275/RSAL/QPL/SSPL/CPOL/NPL1.*/CC-BY
+ # dependency in LICENSE and NOTICE file
+ COUNT=$(grep -E "GPL|BCL|JSR-275|RSAL|QPL|SSPL|CPOL|NPL1|CC-BY" LICENSE NOTICE | wc -l)
+ if [[ $COUNT -ne 0 ]]; then
+ grep -E "GPL|BCL|JSR-275|RSAL|QPL|SSPL|CPOL|NPL1.0|CC-BY" LICENSE NOTICE
+ echo "The package shouldn't include GPL* invalid dependency, but get $COUNT" && exit 1
+ fi
- # 4.2 ensure doesn't contains empty directory or file
+ # 4.3 ensure doesn't contains empty directory or file
COUNT=$(find . -type d -empty | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type d -empty
- echo "The package shouldn't include empty directory, but get $COUNT" # TODO: && exit 1
+ echo "The package shouldn't include empty directory, but get $COUNT" && exit 1
fi
- # 4.3 ensure any file should less than 900kb & not include binary file
+ # 4.4 ensure any file should less than 900kb & not include binary file
COUNT=$(find . -type f -size +900k | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type f -size +900k
- echo "The package shouldn't include file larger than 900kb, but get $COUNT"
+ echo "The package shouldn't include file larger than 900kb, but get $COUNT" && exit 1
fi
COUNT=$(find . -type f | perl -lne 'print if -B' | grep -v *.txt | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type f | perl -lne 'print if -B'
+ # due to the search script is not perfect, we can't exit here (check manually)
echo "The package shouldn't include binary file, but get $COUNT"
Review Comment:
> Find a critical problem here, we need exclude the files with a `white-list` & exit here:
>
> 1. `*.txt` should be allowed, but why `grep -v *.txt` **doesn't work**?
> 2. exclude the file `/hugegraph-hubble/hubble-fe/src/assets/imgs/logo.png`
> 3. exclude the file `./hugegraph-hubble/hubble-fe/public/favicon.ico`
> 4. exclude the file `yarn.lock`
>
> This is the **1st priority** we need to fix and enhance it
1.should exit while check failed ?
2.use 'grep --exclude=*.{txt}' to exclude *.txt , and similar to others ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-doc] imbajin merged pull request #197: validate release actions support mulit os
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-doc] z7658329 commented on a diff in pull request #197: validate release actions support mulit os
Posted by "z7658329 (via GitHub)" <gi...@apache.org>.
z7658329 commented on code in PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#discussion_r1103731969
##########
.github/workflows/validate-release.yml:
##########
@@ -250,3 +270,4 @@ jobs:
fail-fast: false
matrix:
java_version: [ '8','11' ]
+ os: [ubuntu-latest, macos-latest] # TODO: support windows-latest or other os in future
Review Comment:
i try to find centos, It doesn't seem to be found
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-doc] imbajin commented on a diff in pull request #197: validate release actions support mulit os
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#discussion_r1104598615
##########
.github/workflows/validate-release.yml:
##########
@@ -104,32 +108,41 @@ jobs:
if [[ ! -f "DISCLAIMER" ]]; then
echo "The package should include DISCLAIMER file" && exit 1
fi
+ # 4.2 ensure doesn't contains *GPL/BCL/JSR-275/RSAL/QPL/SSPL/CPOL/NPL1.*/CC-BY
+ # dependency in LICENSE and NOTICE file
+ COUNT=$(grep -E "GPL|BCL|JSR-275|RSAL|QPL|SSPL|CPOL|NPL1|CC-BY" LICENSE NOTICE | wc -l)
+ if [[ $COUNT -ne 0 ]]; then
+ grep -E "GPL|BCL|JSR-275|RSAL|QPL|SSPL|CPOL|NPL1.0|CC-BY" LICENSE NOTICE
+ echo "The package shouldn't include GPL* invalid dependency, but get $COUNT" && exit 1
+ fi
- # 4.2 ensure doesn't contains empty directory or file
+ # 4.3 ensure doesn't contains empty directory or file
COUNT=$(find . -type d -empty | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type d -empty
- echo "The package shouldn't include empty directory, but get $COUNT" # TODO: && exit 1
+ echo "The package shouldn't include empty directory, but get $COUNT" && exit 1
fi
- # 4.3 ensure any file should less than 900kb & not include binary file
+ # 4.4 ensure any file should less than 900kb & not include binary file
COUNT=$(find . -type f -size +900k | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type f -size +900k
- echo "The package shouldn't include file larger than 900kb, but get $COUNT"
+ echo "The package shouldn't include file larger than 900kb, but get $COUNT" && exit 1
fi
COUNT=$(find . -type f | perl -lne 'print if -B' | grep -v *.txt | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type f | perl -lne 'print if -B'
+ # due to the search script is not perfect, we can't exit here (check manually)
echo "The package shouldn't include binary file, but get $COUNT"
Review Comment:
Find a critical problem here, we need exclude the files with a `white-list` & exit here:
1. `*.txt` should be allowed, but why `grep -v *.txt` **doesn't work**?
2. exclude the file `/hugegraph-hubble/hubble-fe/src/assets/imgs/logo.png`
3. exclude the file `./hugegraph-hubble/hubble-fe/public/favicon.ico`
4. exclude the file `yarn.lock`
This is the **1st priority** we need to fix and enhance it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-doc] imbajin commented on a diff in pull request #197: validate release actions support mulit os
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#discussion_r1104598615
##########
.github/workflows/validate-release.yml:
##########
@@ -104,32 +108,41 @@ jobs:
if [[ ! -f "DISCLAIMER" ]]; then
echo "The package should include DISCLAIMER file" && exit 1
fi
+ # 4.2 ensure doesn't contains *GPL/BCL/JSR-275/RSAL/QPL/SSPL/CPOL/NPL1.*/CC-BY
+ # dependency in LICENSE and NOTICE file
+ COUNT=$(grep -E "GPL|BCL|JSR-275|RSAL|QPL|SSPL|CPOL|NPL1|CC-BY" LICENSE NOTICE | wc -l)
+ if [[ $COUNT -ne 0 ]]; then
+ grep -E "GPL|BCL|JSR-275|RSAL|QPL|SSPL|CPOL|NPL1.0|CC-BY" LICENSE NOTICE
+ echo "The package shouldn't include GPL* invalid dependency, but get $COUNT" && exit 1
+ fi
- # 4.2 ensure doesn't contains empty directory or file
+ # 4.3 ensure doesn't contains empty directory or file
COUNT=$(find . -type d -empty | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type d -empty
- echo "The package shouldn't include empty directory, but get $COUNT" # TODO: && exit 1
+ echo "The package shouldn't include empty directory, but get $COUNT" && exit 1
fi
- # 4.3 ensure any file should less than 900kb & not include binary file
+ # 4.4 ensure any file should less than 900kb & not include binary file
COUNT=$(find . -type f -size +900k | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type f -size +900k
- echo "The package shouldn't include file larger than 900kb, but get $COUNT"
+ echo "The package shouldn't include file larger than 900kb, but get $COUNT" && exit 1
fi
COUNT=$(find . -type f | perl -lne 'print if -B' | grep -v *.txt | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type f | perl -lne 'print if -B'
+ # due to the search script is not perfect, we can't exit here (check manually)
echo "The package shouldn't include binary file, but get $COUNT"
Review Comment:
Find a critical problem here, we need exclude the files with a `white-list` & exit here:
1. `*.txt` should be allowed, but why `grep -v *.txt` **doesn't work**?
2. exclude the file `/hugegraph-hubble/hubble-fe/src/assets/imgs/logo.png`
3. exclude the file `./hugegraph-hubble/hubble-fe/public/favicon.ico`
4. exclude the file `yarn.lock`
This is the 1st priority we need to fix and enhance it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-doc] z7658329 commented on a diff in pull request #197: validate release actions support mulit os
Posted by "z7658329 (via GitHub)" <gi...@apache.org>.
z7658329 commented on code in PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#discussion_r1105131879
##########
.github/workflows/validate-release.yml:
##########
@@ -104,32 +108,41 @@ jobs:
if [[ ! -f "DISCLAIMER" ]]; then
echo "The package should include DISCLAIMER file" && exit 1
fi
+ # 4.2 ensure doesn't contains *GPL/BCL/JSR-275/RSAL/QPL/SSPL/CPOL/NPL1.*/CC-BY
+ # dependency in LICENSE and NOTICE file
+ COUNT=$(grep -E "GPL|BCL|JSR-275|RSAL|QPL|SSPL|CPOL|NPL1|CC-BY" LICENSE NOTICE | wc -l)
+ if [[ $COUNT -ne 0 ]]; then
+ grep -E "GPL|BCL|JSR-275|RSAL|QPL|SSPL|CPOL|NPL1.0|CC-BY" LICENSE NOTICE
+ echo "The package shouldn't include GPL* invalid dependency, but get $COUNT" && exit 1
+ fi
- # 4.2 ensure doesn't contains empty directory or file
+ # 4.3 ensure doesn't contains empty directory or file
COUNT=$(find . -type d -empty | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type d -empty
- echo "The package shouldn't include empty directory, but get $COUNT" # TODO: && exit 1
+ echo "The package shouldn't include empty directory, but get $COUNT" && exit 1
fi
- # 4.3 ensure any file should less than 900kb & not include binary file
+ # 4.4 ensure any file should less than 900kb & not include binary file
COUNT=$(find . -type f -size +900k | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type f -size +900k
- echo "The package shouldn't include file larger than 900kb, but get $COUNT"
+ echo "The package shouldn't include file larger than 900kb, but get $COUNT" && exit 1
fi
COUNT=$(find . -type f | perl -lne 'print if -B' | grep -v *.txt | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type f | perl -lne 'print if -B'
+ # due to the search script is not perfect, we can't exit here (check manually)
echo "The package shouldn't include binary file, but get $COUNT"
Review Comment:
> Find a critical problem here, we need exclude the files with a `white-list` & exit here:
>
> 1. `*.txt` should be allowed, but why `grep -v *.txt` **doesn't work**?
> 2. exclude the file `/hugegraph-hubble/hubble-fe/src/assets/imgs/logo.png`
> 3. exclude the file `./hugegraph-hubble/hubble-fe/public/favicon.ico`
> 4. exclude the file `yarn.lock`
>
> This is the **1st priority** we need to fix and enhance it
1.should exit while check failed ?
2.use 'grep --exclude=*.{txt}' to exclude *.txt , and similar to others ?
exclude works in my repo test,see: https://github.com/z7658329/incubator-hugegraph-doc/actions/runs/4168898449/jobs/7216220550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-doc] imbajin commented on pull request #197: validate release actions support mulit os
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#issuecomment-1500078869
@z7658329 merge this PR first, and enhance it later (due to we lack the script now 😢)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] validate release actions support mulit os [incubator-hugegraph-doc]
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#issuecomment-1962837752
> Address the comment in another PR
@imbajin could you please check all the comments are addressed?
https://github.com/apache/incubator-hugegraph-doc/blob/master/dist/validate-release.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-doc] javeme commented on a diff in pull request #197: validate release actions support mulit os
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on code in PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#discussion_r1104496932
##########
.github/workflows/validate-release.yml:
##########
@@ -180,6 +182,7 @@ jobs:
echo "test hubble"
cd ./*hubble*${{ inputs.release_version }} || exit
cat conf/hugegraph-hubble.properties && bin/start-hubble.sh
+ # TODO: need stop the server here
Review Comment:
we can also add `# kill the HugeGraphServer process by jps` at line 154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-doc] z7658329 commented on a diff in pull request #197: validate release actions support mulit os
Posted by "z7658329 (via GitHub)" <gi...@apache.org>.
z7658329 commented on code in PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#discussion_r1105103167
##########
.github/workflows/validate-release.yml:
##########
@@ -180,6 +182,7 @@ jobs:
echo "test hubble"
cd ./*hubble*${{ inputs.release_version }} || exit
cat conf/hugegraph-hubble.properties && bin/start-hubble.sh
+ # TODO: need stop the server here
Review Comment:
> we can also add `# kill the HugeGraphServer process by jps` at line 154
seems should stop server after toolchain test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-doc] imbajin commented on a diff in pull request #197: validate release actions support mulit os
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #197:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/197#discussion_r1103645444
##########
.github/workflows/validate-release.yml:
##########
@@ -104,27 +109,34 @@ jobs:
if [[ ! -f "DISCLAIMER" ]]; then
echo "The package should include DISCLAIMER file" && exit 1
fi
+ # 4.2 ensure doesn't contains *GPL/BCL/JSR-275/RSAL/QPL/SSPL/CPOL/NPL1.*/CC-BY
+ # dependency in LICENSE and NOTICE file
+ COUNT=$(grep -E "GPL|BCL|JSR-275|RSAL|QPL|SSPL|CPOL|NPL1|CC-BY" LICENSE NOTICE | wc -l)
+ if [[ $COUNT -ne 0 ]]; then
+ grep -E "GPL|BCL|JSR-275|RSAL|QPL|SSPL|CPOL|NPL1.0|CC-BY" LICENSE NOTICE
+ echo "The package shouldn't include GPL* invalid dependency, but get $COUNT" && exit 1
+ fi
- # 4.2 ensure doesn't contains empty directory or file
+ # 4.3 ensure doesn't contains empty directory or file
COUNT=$(find . -type d -empty | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type d -empty
- echo "The package shouldn't include empty directory, but get $COUNT" # TODO: && exit 1
+ echo "The package shouldn't include empty directory, but get $COUNT" && exit 1
fi
- # 4.3 ensure any file should less than 900kb & not include binary file
+ # 4.4 ensure any file should less than 900kb & not include binary file
COUNT=$(find . -type f -size +900k | wc -l)
if [[ $COUNT -ne 0 ]]; then
find . -type f -size +900k
- echo "The package shouldn't include file larger than 900kb, but get $COUNT"
+ echo "The package shouldn't include file larger than 900kb, but get $COUNT" && exit 1
fi
COUNT=$(find . -type f | perl -lne 'print if -B' | grep -v *.txt | wc -l)
Review Comment:
need a better way to search binary files（and exclude some files marked in properties）
no we can't exit here，but we should search the key word in action log manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org