You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2016/02/19 20:49:47 UTC
Re: Review Request 43744: PMD: Fix code that violates
EmptyFinallyBlock rule
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43744/#review119959
-----------------------------------------------------------
Ship it!
Alok - lookup-client project may not be used at all. Its contents were moved into individual plugin project in ranger-0.5 release. Please verify and if unused, remove the project.
- Madhan Neethiraj
On Feb. 18, 2016, 11:33 p.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43744/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 11:33 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-851
> https://issues.apache.org/jira/browse/RANGER-851
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fixed code that violates EmptyFinallyBlock rule.
> Removed EmptyFinallyBlock rule from exclude list so new occurances are flagged.
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/provider/hdfs/HdfsLogDestination.java a9aa8c1
> agents-cred/src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java 7939ae5
> dev-support/ranger-pmd-ruleset.xml 1f74845
> hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java 779133f
> knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java 6859492
> lookup-client/src/main/java/org/apache/ranger/hadoop/client/HadoopFS.java 10a83c3
> lookup-client/src/main/java/org/apache/ranger/knox/client/KnoxClient.java 6441ec3
> security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 514a63e
>
> Diff: https://reviews.apache.org/r/43744/diff/
>
>
> Testing
> -------
>
> existing tests work
>
>
> Thanks,
>
> Alok Lal
>
>