You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/03/06 05:31:30 UTC

[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4454: [KYUUBI #4452] Strip the redundant leading and tailing slash of getZooKeeperNamespace.

pan3793 commented on code in PR #4454:
URL: https://github.com/apache/kyuubi/pull/4454#discussion_r1125932959


##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/ZooKeeperHiveClientHelper.java:
##########
@@ -112,7 +115,7 @@ static void configureConnParams(JdbcConnectionParams connParams)
       updateParamsWithZKServerNode(connParams, zooKeeperClient, serverNode);
     } catch (Exception e) {
       throw new ZooKeeperHiveClientException(
-          "Unable to read HiveServer2 configs from ZooKeeper", e);
+          "Unable to read HiveServer2 configs from ZooKeeper: " + e.getMessage());

Review Comment:
   why change it? we should propagate the inner exception otherwise we will lost the stacktrace



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org