You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/01/19 21:56:34 UTC
[Impala-ASF-CR] IMPALA-6427: fix QUERYOPTIONS in planner test output
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9081
Change subject: IMPALA-6427: fix QUERYOPTIONS in planner test output
......................................................................
IMPALA-6427: fix QUERYOPTIONS in planner test output
Testing:
Ran planner tests. Confirmed that the generated union.test
included the QUERYOPTIONS section and that test files without the
QUERYOPTIONS section did not have QUERYOPTIONS sections added.
Change-Id: I2971588f977f72b0f869370803b089d56303d91a
---
M fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/9081/1
--
To view, visit http://gerrit.cloudera.org:8080/9081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2971588f977f72b0f869370803b089d56303d91a
Gerrit-Change-Number: 9081
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6427: fix QUERYOPTIONS in planner test output
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9081 )
Change subject: IMPALA-6427: fix QUERYOPTIONS in planner test output
......................................................................
Patch Set 1: Code-Review+2
thx for fixing
--
To view, visit http://gerrit.cloudera.org:8080/9081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2971588f977f72b0f869370803b089d56303d91a
Gerrit-Change-Number: 9081
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Jan 2018 00:44:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6427: fix QUERYOPTIONS in planner test output
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9081 )
Change subject: IMPALA-6427: fix QUERYOPTIONS in planner test output
......................................................................
IMPALA-6427: fix QUERYOPTIONS in planner test output
Testing:
Ran planner tests. Confirmed that the generated union.test
included the QUERYOPTIONS section and that test files without the
QUERYOPTIONS section did not have QUERYOPTIONS sections added.
Change-Id: I2971588f977f72b0f869370803b089d56303d91a
Reviewed-on: http://gerrit.cloudera.org:8080/9081
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Alex Behm: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2971588f977f72b0f869370803b089d56303d91a
Gerrit-Change-Number: 9081
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-6427: fix QUERYOPTIONS in planner test output
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9081 )
Change subject: IMPALA-6427: fix QUERYOPTIONS in planner test output
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2971588f977f72b0f869370803b089d56303d91a
Gerrit-Change-Number: 9081
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Sat, 20 Jan 2018 05:14:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6427: fix QUERYOPTIONS in planner test output
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9081 )
Change subject: IMPALA-6427: fix QUERYOPTIONS in planner test output
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1768/
--
To view, visit http://gerrit.cloudera.org:8080/9081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2971588f977f72b0f869370803b089d56303d91a
Gerrit-Change-Number: 9081
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Sat, 20 Jan 2018 01:27:10 +0000
Gerrit-HasComments: No