You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/27 06:28:03 UTC
[GitHub] [flink-ml] weibozhao opened a new pull request, #118: Add benchmark of VectorAssembler and MinMaxScaler
weibozhao opened a new pull request, #118:
URL: https://github.com/apache/flink-ml/pull/118
Add benchmark of vectorAssembler and minmaxScaler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] weibozhao commented on a diff in pull request #118: [FLINK-28254] Add benchmark of VectorAssembler and MinMaxScaler
Posted by GitBox <gi...@apache.org>.
weibozhao commented on code in PR #118:
URL: https://github.com/apache/flink-ml/pull/118#discussion_r907315801
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/ColsWithLabelGenerator.java:
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.benchmark.datagenerator.common;
+
+import org.apache.flink.api.common.functions.RichMapFunction;
+import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeinfo.Types;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.ml.benchmark.datagenerator.InputDataGenerator;
+import org.apache.flink.ml.benchmark.datagenerator.param.HasVectorDim;
+import org.apache.flink.ml.common.datastream.TableUtils;
+import org.apache.flink.ml.param.Param;
+import org.apache.flink.ml.util.ParamUtils;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.NumberSequenceIterator;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Random;
+
+/** A DataGenerator which creates a table of column features with label. */
+public class ColsWithLabelGenerator
+ implements InputDataGenerator<ColsWithLabelGenerator>,
+ HasVectorDim<ColsWithLabelGenerator> {
+
+ private final Map<Param<?>, Object> paramMap = new HashMap<>();
+
+ public ColsWithLabelGenerator() {
+ ParamUtils.initializeMapWithDefaultValues(paramMap, this);
+ }
+
+ @Override
+ public Table[] getData(StreamTableEnvironment tEnv) {
+
+ StreamExecutionEnvironment env = TableUtils.getExecutionEnvironment(tEnv);
+ TypeInformation<?>[] types;
+ String[] colNames;
+ if (getColNames().length == 2) {
+ colNames = new String[getColNames()[0].length + 1];
+
+ types = new TypeInformation<?>[getColNames()[0].length + 1];
+ for (int i = 0; i < getColNames()[0].length; ++i) {
+ colNames[i] = getColNames()[0][i];
+ types[i] = Types.DOUBLE;
+ }
+ colNames[colNames.length - 1] = getColNames()[1][0];
+ types[colNames.length - 1] = Types.DOUBLE;
+ } else {
+ colNames = getColNames()[0];
+ types = new TypeInformation<?>[getColNames()[0].length];
+ for (int i = 0; i < colNames.length; ++i) {
+ types[i] = Types.DOUBLE;
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] lindong28 closed pull request #118: [FLINK-28254] Add benchmark of VectorAssembler and MinMaxScaler
Posted by GitBox <gi...@apache.org>.
lindong28 closed pull request #118: [FLINK-28254] Add benchmark of VectorAssembler and MinMaxScaler
URL: https://github.com/apache/flink-ml/pull/118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #118: [FLINK-28254] Add benchmark of VectorAssembler and MinMaxScaler
Posted by GitBox <gi...@apache.org>.
yunfengzhou-hub commented on code in PR #118:
URL: https://github.com/apache/flink-ml/pull/118#discussion_r907935305
##########
flink-ml-benchmark/src/main/resources/minmaxscaler-benchmark.json:
##########
@@ -0,0 +1,42 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+{
+ "version": 1,
+ "minmaxscaler10000000": {
+ "inputData": {
+ "className": "org.apache.flink.ml.benchmark.datagenerator.common.DenseVectorGenerator",
+ "paramMap": {
+ "vectorDim": 100,
+ "colNames": [
+ [
+ "features"
+ ]
+ ],
+ "seed": 2,
+ "numValues": 10000000
+ }
+ },
+ "stage": {
+ "className": "org.apache.flink.ml.feature.minmaxscaler.MinMaxScaler",
+ "paramMap": {
+ "inputCol": "features",
+ "withMean": true,
+ "withStd": true,
+ "outputCol": "outputCol"
+ }
+ }
+ }
+}
Review Comment:
It seems that this json file cannot be executed. Could you please check if its grammar is correct?
##########
flink-ml-benchmark/src/main/resources/minmaxscaler-benchmark.json:
##########
@@ -0,0 +1,42 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
Let's rebase the commits in this PR into one to improve its readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #118: Add benchmark of VectorAssembler and MinMaxScaler
Posted by GitBox <gi...@apache.org>.
yunfengzhou-hub commented on code in PR #118:
URL: https://github.com/apache/flink-ml/pull/118#discussion_r907051827
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/ColsWithLabelGenerator.java:
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.benchmark.datagenerator.common;
+
+import org.apache.flink.api.common.functions.RichMapFunction;
+import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeinfo.Types;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.ml.benchmark.datagenerator.InputDataGenerator;
+import org.apache.flink.ml.benchmark.datagenerator.param.HasVectorDim;
+import org.apache.flink.ml.common.datastream.TableUtils;
+import org.apache.flink.ml.param.Param;
+import org.apache.flink.ml.util.ParamUtils;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.NumberSequenceIterator;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Random;
+
+/** A DataGenerator which creates a table of column features with label. */
+public class ColsWithLabelGenerator
+ implements InputDataGenerator<ColsWithLabelGenerator>,
+ HasVectorDim<ColsWithLabelGenerator> {
+
+ private final Map<Param<?>, Object> paramMap = new HashMap<>();
+
+ public ColsWithLabelGenerator() {
+ ParamUtils.initializeMapWithDefaultValues(paramMap, this);
+ }
+
+ @Override
+ public Table[] getData(StreamTableEnvironment tEnv) {
+
+ StreamExecutionEnvironment env = TableUtils.getExecutionEnvironment(tEnv);
+ TypeInformation<?>[] types;
+ String[] colNames;
+ if (getColNames().length == 2) {
+ colNames = new String[getColNames()[0].length + 1];
+
+ types = new TypeInformation<?>[getColNames()[0].length + 1];
+ for (int i = 0; i < getColNames()[0].length; ++i) {
+ colNames[i] = getColNames()[0][i];
+ types[i] = Types.DOUBLE;
+ }
+ colNames[colNames.length - 1] = getColNames()[1][0];
+ types[colNames.length - 1] = Types.DOUBLE;
+ } else {
+ colNames = getColNames()[0];
+ types = new TypeInformation<?>[getColNames()[0].length];
+ for (int i = 0; i < colNames.length; ++i) {
+ types[i] = Types.DOUBLE;
+ }
+ }
+ DataStream<Row> dataStream =
+ env.fromParallelCollection(
+ new NumberSequenceIterator(1L, getNumValues()),
+ BasicTypeInfo.LONG_TYPE_INFO)
+ .map(
+ new ColsGenerator(getSeed(), colNames),
+ new RowTypeInfo(types, colNames));
+
+ Table dataTable = tEnv.fromDataStream(dataStream);
+
+ return new Table[] {dataTable};
+ }
+
+ @Override
+ public Map<Param<?>, Object> getParamMap() {
+ return paramMap;
+ }
+
+ private static class ColsGenerator extends RichMapFunction<Long, Row> {
+ private final long initSeed;
+ private final String[] colNames;
+ private Random random;
+
+ private ColsGenerator(long initSeed, String[] colNames) {
+ this.initSeed = initSeed;
+ this.colNames = colNames;
+ }
+
+ @Override
+ public void open(Configuration parameters) throws Exception {
+ super.open(parameters);
+ int index = getRuntimeContext().getIndexOfThisSubtask();
+ random = new Random(Tuple2.of(initSeed, index).hashCode());
+ }
+
+ @Override
+ public Row map(Long ignored) {
+ Row ret = new Row(colNames.length);
+ for (int i = 0; i < colNames.length - 1; ++i) {
+ ret.setField(i, random.nextDouble());
+ }
+ ret.setField(colNames.length - 1, random.nextDouble() > 0.5 ? 1.0 : 0.0);
+ return ret;
+ }
+ }
+}
Review Comment:
nit: Let's follow the common practice to add a blank line at the end of each file.
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/ColsWithLabelGenerator.java:
##########
@@ -0,0 +1,123 @@
+/*
Review Comment:
Let's add `[FLINK-27096]` to the title and commit message of this PR. It has been the parent ticket for all PRs related to algorithm benchmark and performance improvement before 2.1 release.
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/ColsWithLabelGenerator.java:
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.benchmark.datagenerator.common;
+
+import org.apache.flink.api.common.functions.RichMapFunction;
+import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeinfo.Types;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.ml.benchmark.datagenerator.InputDataGenerator;
+import org.apache.flink.ml.benchmark.datagenerator.param.HasVectorDim;
+import org.apache.flink.ml.common.datastream.TableUtils;
+import org.apache.flink.ml.param.Param;
+import org.apache.flink.ml.util.ParamUtils;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.NumberSequenceIterator;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Random;
+
+/** A DataGenerator which creates a table of column features with label. */
+public class ColsWithLabelGenerator
+ implements InputDataGenerator<ColsWithLabelGenerator>,
+ HasVectorDim<ColsWithLabelGenerator> {
+
+ private final Map<Param<?>, Object> paramMap = new HashMap<>();
+
+ public ColsWithLabelGenerator() {
+ ParamUtils.initializeMapWithDefaultValues(paramMap, this);
+ }
+
+ @Override
+ public Table[] getData(StreamTableEnvironment tEnv) {
+
+ StreamExecutionEnvironment env = TableUtils.getExecutionEnvironment(tEnv);
+ TypeInformation<?>[] types;
+ String[] colNames;
+ if (getColNames().length == 2) {
+ colNames = new String[getColNames()[0].length + 1];
+
+ types = new TypeInformation<?>[getColNames()[0].length + 1];
+ for (int i = 0; i < getColNames()[0].length; ++i) {
+ colNames[i] = getColNames()[0][i];
+ types[i] = Types.DOUBLE;
+ }
+ colNames[colNames.length - 1] = getColNames()[1][0];
+ types[colNames.length - 1] = Types.DOUBLE;
+ } else {
+ colNames = getColNames()[0];
+ types = new TypeInformation<?>[getColNames()[0].length];
+ for (int i = 0; i < colNames.length; ++i) {
+ types[i] = Types.DOUBLE;
Review Comment:
Do you think it would be better to reuse `DoubleGenerator` or `DenseVectorGenerator`? I can see that this data generator is used for vector assembler benchmark, so inputting multiple double/vector columns should be enough for current use cases. For now `DoubleGenerator` or `DenseVectorGenerator` only generates one double/vector column, and we can modify them to generate arbitrary number of double/vector columns, according to the number of columns acquired from `getColNames()`. The label column seems unnecessary for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] lindong28 commented on pull request #118: [FLINK-28254] Add benchmark of VectorAssembler and MinMaxScaler
Posted by GitBox <gi...@apache.org>.
lindong28 commented on PR #118:
URL: https://github.com/apache/flink-ml/pull/118#issuecomment-1168804985
LGTM. Merged to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] lindong28 commented on pull request #118: [FLINK-28254] Add benchmark of VectorAssembler and MinMaxScaler
Posted by GitBox <gi...@apache.org>.
lindong28 commented on PR #118:
URL: https://github.com/apache/flink-ml/pull/118#issuecomment-1168800399
Thanks @weibozhao for the PR. Thanks @yunfengzhou-hub for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org