[GitHub] [superset] exemplary-citizen commented on a change in pull request #14449: feat: Allow csv upload to accept parquet file

[GitBox <gi...@apache.org>]

exemplary-citizen commented on a change in pull request #14449:
URL: https://github.com/apache/superset/pull/14449#discussion_r646243432



##########
File path: superset/views/database/forms.py
##########
@@ -163,6 +169,15 @@ def at_least_one_schema_is_allowed(database: Database) -> bool:
         _("Mangle Duplicate Columns"),
         description=_('Specify duplicate columns as "X.0, X.1".'),
     )
+    usecols = JsonListField(
+        _("Use Columns"),
+        default=None,
+        description=_(
+            "Json list of the column names that should be read. "
+            "If not None, only these columns will be read from the file."
+        ),
+        validators=[Optional()],
+    )

Review comment:
       @villebro do you still want to keep the `Use Columns` feature in the csv form? if so, should we keep it in this PR or move it to a separate one? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org