[GitHub] [beam] chamikaramj commented on a change in pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3

[GitBox <gi...@apache.org>]

chamikaramj commented on a change in pull request #11651:
URL: https://github.com/apache/beam/pull/11651#discussion_r427580442



##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -489,6 +490,7 @@ class BeamModulePlugin implements Plugin<Project> {
         grpc_protobuf                               : "io.grpc:grpc-protobuf:$grpc_version",
         grpc_protobuf_lite                          : "io.grpc:grpc-protobuf-lite:$grpc_version",
         grpc_netty                                  : "io.grpc:grpc-netty:$grpc_version",
+        grpc_netty_shaded                           : "io.grpc:grpc-netty-shaded:$grpc_version",

Review comment:
       Why do we need both grpc_netty and grpc_netty_shaded ?

##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -56,11 +56,13 @@ dependencies {
   compile library.java.google_http_client
   compile library.java.google_http_client_jackson2
   compile library.java.grpc_all
+  compile library.java.grpc_alts
   compile library.java.grpc_auth
   compile library.java.grpc_core
   compile library.java.grpc_context
   compile library.java.grpc_grpclb
   compile library.java.grpc_netty
+  compile library.java.grpc_netty_shaded

Review comment:
       Ditto.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org