You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2023/02/02 01:08:47 UTC

[spark] branch branch-3.4 updated: [SPARK-42284][CONNECT] Make sure connect server assembly is built before running client tests - SBT

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch branch-3.4
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.4 by this push:
     new bdf292c683b [SPARK-42284][CONNECT] Make sure connect server assembly is built before running client tests - SBT
bdf292c683b is described below

commit bdf292c683b524d166b9190414df6238f347e68c
Author: Herman van Hovell <he...@databricks.com>
AuthorDate: Thu Feb 2 10:08:25 2023 +0900

    [SPARK-42284][CONNECT] Make sure connect server assembly is built before running client tests - SBT
    
    ### What changes were proposed in this pull request?
    This PR makes sure SBT assembles the connect server assembly jar before we run client tests.
    
    ### Why are the changes needed?
    It makes it easier to develop and test the JVM client for Spark Connect.
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    Manually tested.
    
    Closes #39854 from hvanhovell/SPARK-42284.
    
    Authored-by: Herman van Hovell <he...@databricks.com>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
    (cherry picked from commit 10b97f812152ffc1074c3ad937005617b05cc411)
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 project/SparkBuild.scala | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/project/SparkBuild.scala b/project/SparkBuild.scala
index 9579123c25c..4eb17e88d4d 100644
--- a/project/SparkBuild.scala
+++ b/project/SparkBuild.scala
@@ -851,6 +851,9 @@ object SparkConnectClient {
       )
     },
 
+    // Make sure the connect server assembly jar is available for testing.
+    test := ((Test / test) dependsOn (LocalProject("connect") / assembly)).value,
+
     (assembly / test) := { },
 
     (assembly / logLevel) := Level.Info,


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org