You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2018/06/06 08:20:17 UTC
Re: Review Request 67357: Added constant time comparison of JWT
signatures.
> On May 31, 2018, 6:56 p.m., Benno Evers wrote:
> > 3rdparty/libprocess/src/jwt.cpp
> > Lines 205 (patched)
> > <https://reviews.apache.org/r/67357/diff/2/?file=2033221#file2033221line205>
> >
> > To be more precise: "which compares either none of the content or the whole content of the strings".
> >
> > (but actually I'm not even sure a comment is needed at all, the function name kinda speaks for itself)
I agree but the shepherd requested it ;)
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67357/#review204122
-----------------------------------------------------------
On May 31, 2018, 11:02 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67357/
> -----------------------------------------------------------
>
> (Updated May 31, 2018, 11:02 a.m.)
>
>
> Review request for Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A vulnerability in our JWT implementation allows an unauthenticated
> remote attacker to execute to execute timing attacks [1].
>
> This patch removes the vulnerability by adding a constant time
> comparison of hashes, where the whole message is visited during
> the comparison instead of returning at the first failure.
>
> [1] https://codahale.com/a-lesson-in-timing-attacks/
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/jwt.cpp 4477ddd17dede2b924a47e33942b39244f10316f
>
>
> Diff: https://reviews.apache.org/r/67357/diff/2/
>
>
> Testing
> -------
>
> ```sh
> make check
> ```
>
>
> Thanks,
>
> Alexander Rojas
>
>