You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kris-gaudel (via GitHub)" <gi...@apache.org> on 2025/05/30 14:40:57 UTC

[PR] feat(arrow/_examples): enhance library examples [arrow-go]

kris-gaudel opened a new pull request, #394:
URL: https://github.com/apache/arrow-go/pull/394

   ### Rationale for this change
   Enhancing the examples in the `_examples` folder
   
   ### What changes are included in this PR?
   3 new examples on how to use the `arrow-go` library:
   - Reading from a CSV file
   - Type conversions
   - Managing performance
   
   ### Are these changes tested?
   Not applicable
   
   ### Are there any user-facing changes?
   No, just enhancing examples


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(arrow/_examples): enhance library examples [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #394:
URL: https://github.com/apache/arrow-go/pull/394#issuecomment-2967516520

   That's a transient leak that I haven't been able to track down myself. If you're able to track it down and fix it, that would be amazing! It can definitely be a separate PR and doesn't need to be dealt with in this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(arrow/_examples): enhance library examples [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #394:
URL: https://github.com/apache/arrow-go/pull/394#issuecomment-2963299731

   @kris-gaudel looks like you need to update the tinygo test script because you renamed/moved the helloworld/main.go file :smile: that's probably the last thing we need before we can merge this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(arrow/_examples): enhance library examples [arrow-go]

Posted by "kris-gaudel (via GitHub)" <gi...@apache.org>.
kris-gaudel commented on PR #394:
URL: https://github.com/apache/arrow-go/pull/394#issuecomment-2967505373

   It looks like there is a memory leak in one of the tests, should I fix it in this PR or make a separate one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(arrow/_examples): enhance library examples [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #394:
URL: https://github.com/apache/arrow-go/pull/394


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(arrow/_examples): enhance library examples [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #394:
URL: https://github.com/apache/arrow-go/pull/394#issuecomment-2922908873

   Instead of using the `_examples` folder, could we instead make these [testable examples](https://go.dev/blog/examples) in the appropriate locations so they show up in the docs directly next to the relevant code?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(arrow/_examples): enhance library examples [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #394:
URL: https://github.com/apache/arrow-go/pull/394#issuecomment-2923674748

   Some files are missing the Apache license header, adding that should fix the CI 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(arrow/_examples): enhance library examples [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #394:
URL: https://github.com/apache/arrow-go/pull/394#issuecomment-2963187877

   hey i'm super sorry this is taking so long! I've been traveling for a conference. I'll review this and hopefully merge it today


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org