You are viewing a plain text version of this content. The canonical link for it is here.
Posted to docs-dev@perl.apache.org by Stas Bekman <st...@stason.org> on 2004/08/12 21:46:01 UTC

Re: Website printing docs PATCH

allan juul wrote:
> hi
> 
> enclosing patch and print-style sheet for better visual presentation of 
> pritning of the web docs on perl.apache.org
> 
> these are only tested on "modern" browsers (including Lynx) on modern Windows 
> platforms . please test patch if possible or have a preview at
> 
>   http://www.bullitt.suite.dk/dst_html
> 
> basically the idea is that everything should look as always on the screen but 
> the actual print should be trimmed for unnessary stuff (the menus for example)

Nice work, Allan.

Looks good here. May be post this link to the modperl list to see if 
anybody has a problem with your test site above?

the only comment regarding the patch is:

> Index: tmpl/custom/html/headers
> ===================================================================
> RCS file: /home/cvspublic/modperl-docs/tmpl/custom/html/headers,v
> retrieving revision 1.7
> diff -u -r1.7 headers
> --- tmpl/custom/html/headers	12 Jul 2002 07:54:49 -0000	1.7
> +++ tmpl/custom/html/headers	12 Aug 2004 19:11:08 -0000
> @@ -11,6 +11,7 @@
>                  },
>          },
>          link => "<link href=\"${doc.dir.abs_doc_root}/style.css\" 
> rel=\"stylesheet\" type=\"text/css\" title=\"refstyle\">",
> +        link2 => "<link href=\"${doc.dir.abs_doc_root}/print.css\" 
> rel=\"stylesheet\" type=\"text/css\" title=\"refstyle\">",
>  
>  };
>  
> @@ -22,7 +23,7 @@
>          <base href="[% doc.headers.base | uri | html %]">
>  [%- END -%]
>  
> -[%- "        $l\n" FOREACH l = [ doc.headers.link, default_headers.link ] -%]
> +[%- "        $l\n" FOREACH l = [ doc.headers.link, default_headers.link, 
> default_headers.link2 ] -%]
>          <meta name="description" content="mod_perl documentation: [% abstract 
> | html %]">

Better rename s/link2/link_print/? here and there was at least one more 
occurence in the rest of the patch.

Thanks.

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org


Re: Website printing docs PATCH

Posted by Stas Bekman <st...@stason.org>.
allan juul wrote:
> Quoting Stas Bekman <st...@stason.org>:
> 
> posted the below to the mod_perl mailing list and got only postive feedback 
> (albeit very few responses)
> 
> anyway, i consider it pretty safe (and cool) to apply the enclosed patch and 
> style sheet unless people start complaining ;)

Thanks Allan, committed.

I've started the online site rebuild process, so it'll pick up the changes 
soon.

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org


Re: Website printing docs PATCH

Posted by allan juul <la...@inet.uni2.dk>.
Quoting Stas Bekman <st...@stason.org>:

posted the below to the mod_perl mailing list and got only postive feedback 
(albeit very few responses)

anyway, i consider it pretty safe (and cool) to apply the enclosed patch and 
style sheet unless people start complaining ;)

thanks
./allan


> allan juul wrote:
> > hi
> > 
> > enclosing patch and print-style sheet for better visual presentation of 
> > pritning of the web docs on perl.apache.org
> > 
> > these are only tested on "modern" browsers (including Lynx) on modern
> Windows 
> > platforms . please test patch if possible or have a preview at
> > 
> >   http://www.bullitt.suite.dk/dst_html
> > 
> > basically the idea is that everything should look as always on the screen
> but 
> > the actual print should be trimmed for unnessary stuff (the menus for
> example)
> 
> Nice work, Allan.
> 
> Looks good here. May be post this link to the modperl list to see if 
> anybody has a problem with your test site above?
> 
> the only comment regarding the patch is:
> 
> > Index: tmpl/custom/html/headers
> > ===================================================================
> > RCS file: /home/cvspublic/modperl-docs/tmpl/custom/html/headers,v
> > retrieving revision 1.7
> > diff -u -r1.7 headers
> > --- tmpl/custom/html/headers	12 Jul 2002 07:54:49 -0000	1.7
> > +++ tmpl/custom/html/headers	12 Aug 2004 19:11:08 -0000
> > @@ -11,6 +11,7 @@
> >                  },
> >          },
> >          link => "<link href=\"${doc.dir.abs_doc_root}/style.css\" 
> > rel=\"stylesheet\" type=\"text/css\" title=\"refstyle\">",
> > +        link2 => "<link href=\"${doc.dir.abs_doc_root}/print.css\" 
> > rel=\"stylesheet\" type=\"text/css\" title=\"refstyle\">",
> >  
> >  };
> >  
> > @@ -22,7 +23,7 @@
> >          <base href="[% doc.headers.base | uri | html %]">
> >  [%- END -%]
> >  
> > -[%- "        $l\n" FOREACH l = [ doc.headers.link, default_headers.link ]
> -%]
> > +[%- "        $l\n" FOREACH l = [ doc.headers.link, default_headers.link,
> 
> > default_headers.link2 ] -%]
> >          <meta name="description" content="mod_perl documentation: [%
> abstract 
> > | html %]">
> 
> Better rename s/link2/link_print/? here and there was at least one more 
> occurence in the rest of the patch.
> 
> Thanks.
> 
> -- 
> __________________________________________________________________
> Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
> http://stason.org/     mod_perl Guide ---> http://perl.apache.org
> mailto:stas@stason.org http://use.perl.org http://apacheweek.com
> http://modperlbook.org http://apache.org   http://ticketmaster.com
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: docs-dev-help@perl.apache.org
> 
>