You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "onichols-pivotal (GitHub)" <gi...@apache.org> on 2020/03/01 02:05:27 UTC
[GitHub] [geode] onichols-pivotal opened pull request #4750:
GEODE-7833: bump tomcat versions
Although this may affect tests only, bump the tomcat versions as recommended in the ghostcat advisory.
[ Full content available at: https://github.com/apache/geode/pull/4750 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] rhoughton-pivot commented on issue #4750:
GEODE-7833: WIP bump tomcat versions
Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
> are the rmiio-not-found errors now happening in this PR somehow related to your #4720
@onichols-pivotal I'm not an expert at how things are set on the classpath for tomcat service tests. But my change should still put `rmiio` on the regular runtime classpath. You can try explicitly adding `rmiio` to `distributedTestRuntime` and see if that helps. Can you get this to fail locally?
[ Full content available at: https://github.com/apache/geode/pull/4750 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] onichols-pivotal commented on issue #4750:
GEODE-7833: WIP bump tomcat versions
Posted by "onichols-pivotal (GitHub)" <gi...@apache.org>.
> Can you get this to fail locally?
yes, `./gradlew geode-assembly:distributedTest --tests Tomcat9Test` fails locally for me (even after gradle clean and blowing away my ~/.gradle caches).
> try explicitly adding rmiio to distributedTestRuntime
adding `distributedTestRuntimeOnly('com.healthmarketscience.rmiio:rmiio')` in `extensions/geode-modules-tomcat9/build.gradle` made no difference
[ Full content available at: https://github.com/apache/geode/pull/4750 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] onichols-pivotal commented on issue #4750:
GEODE-7833: WIP bump tomcat versions
Posted by "onichols-pivotal (GitHub)" <gi...@apache.org>.
not needed so not going to pursue this further
[ Full content available at: https://github.com/apache/geode/pull/4750 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org