You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ScrapCodes <gi...@git.apache.org> on 2018/01/17 13:10:18 UTC

[GitHub] spark pull request #18143: [SPARK-20919][SS] Simplificaiton of CachedKafkaCo...

Github user ScrapCodes commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18143#discussion_r162045340
  
    --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala ---
    @@ -45,9 +46,6 @@ private[kafka010] case class CachedKafkaConsumer private(
     
       private var consumer = createConsumer
     
    -  /** indicates whether this consumer is in use or not */
    -  private var inuse = true
    --- End diff --
    
    Now that we have moved to using object pools, this tracking is no longer required.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org