You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/08/21 19:39:00 UTC

[jira] [Commented] (GEODE-5585) ConcurrencyRule: Make sure that threads are run

    [ https://issues.apache.org/jira/browse/GEODE-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587919#comment-16587919 ] 

ASF subversion and git services commented on GEODE-5585:
--------------------------------------------------------

Commit 2868c3c0ece3ecab658d1a431bfd753b52537ea5 in geode's branch refs/heads/develop from [~balesh2]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2868c3c ]

GEODE-5585: Check that threads have been run (#2332)

* GEODE-5585: Check that threads have been run

In the ConcurrencyRule's after(), check that all threads that have been
added have been run, to protect from tests having false passes due to
threads never being executed and results gathered. If tests really need
to be added and not run, clear() must be used before after() is invoked.



> ConcurrencyRule: Make sure that threads are run
> -----------------------------------------------
>
>                 Key: GEODE-5585
>                 URL: https://issues.apache.org/jira/browse/GEODE-5585
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Helena Bales
>            Assignee: Helena Bales
>            Priority: Major
>              Labels: pull-request-available, swat
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> With the concurrency rule it is still possible to forget to run the submitted threads. Add a check to the after() for the rule to make sure that threads are run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)