You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/17 13:13:55 UTC

[GitHub] [kafka] cadonna commented on a diff in pull request #12173: MINOR: Add 3.0 to streams system tests (for 3.1 branch)

cadonna commented on code in PR #12173:
URL: https://github.com/apache/kafka/pull/12173#discussion_r874797346


##########
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##########
@@ -21,11 +21,12 @@
 from kafkatest.services.kafka import KafkaService
 from kafkatest.services.streams import StreamsSmokeTestDriverService, StreamsSmokeTestJobRunnerService
 from kafkatest.services.zookeeper import ZookeeperService
-from kafkatest.version import LATEST_2_2, LATEST_2_3, LATEST_2_4, LATEST_2_5, LATEST_2_6, LATEST_2_7, LATEST_2_8, DEV_VERSION, KafkaVersion
+from kafkatest.version import LATEST_2_2, LATEST_2_3, LATEST_2_4, LATEST_2_5, LATEST_2_6, LATEST_2_7, LATEST_2_8, \
+  LATEST_3_0, DEV_VERSION, KafkaVersion
 
 smoke_test_versions = [str(LATEST_2_2), str(LATEST_2_3), str(LATEST_2_4),
                        str(LATEST_2_5), str(LATEST_2_6), str(LATEST_2_7),
-                       str(LATEST_2_8)]
+                       str(LATEST_2_8), str(LATEST_3_0)]

Review Comment:
   Shall we also add 
   ```
   V_3_0_1 = KafkaVersion("3.0.1")
   LATEST_3_0 = V_3_0_1
   ```
   to `tests/kafkatest/version.py`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org