You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vineet Garg <vg...@hortonworks.com> on 2018/07/23 01:43:23 UTC
Review Request 68011: HIVE-19770 Support for CBO for queries with
multiple same columns in select
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68011/
-----------------------------------------------------------
Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.
Bugs: HIVE-19770
https://issues.apache.org/jira/browse/HIVE-19770
Repository: hive-git
Description
-------
See Jira
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java f008c4dfae
ql/src/test/queries/clientnegative/ambiguous_col.q e8f2c8d750
ql/src/test/results/clientnegative/ambiguous_col.q.out a2915a4a5d
ql/src/test/results/clientnegative/create_view_failure5.q.out d79dc64a30
ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out 6c45fcb7ac
ql/src/test/results/clientpositive/char_udf1.q.out 69d76d7269
ql/src/test/results/clientpositive/keyword_2.q.out f1d63b6e5f
ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out 5e766c8982
ql/src/test/results/clientpositive/llap/explainanalyze_2.q.out ab86821f07
ql/src/test/results/clientpositive/llap/explainuser_2.q.out 5f5f5f6015
ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out ebaac18127
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part.q.out 97752f3c25
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_llap_io.q.out 23c33a3141
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out eeabb8cc61
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update_llap_io.q.out f15a144a96
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table.q.out a043b679ae
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_llap_io.q.out 35c1fae6d0
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update.q.out 730d3d2312
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update_llap_io.q.out 95bfa2507d
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_llap_io.q.out 7e1cce3f4f
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update.q.out 242b95e603
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update_llap_io.q.out 53cb8fc8c4
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table.q.out 219ad7a82e
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_llap_io.q.out ce9fe84d1e
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update.q.out f8df92faf7
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update_llap_io.q.out 2292dcb24b
ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part.q.out e02a1e247d
ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive.q.out f70efd6f94
ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive_llap_io.q.out 351d201700
ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_llap_io.q.out 603c669f51
ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table.q.out 454bf264d3
ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table_llap_io.q.out 7ccda3dc91
ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part.q.out e5aa7f418a
ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive.q.out ae483ca2b0
ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive_llap_io.q.out fb1a4d2d33
ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table.q.out ff23f05007
ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table_llap_io.q.out 97c8730c11
ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part.q.out ca2c9088a5
ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive.q.out 29054b1e6e
ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive_llap_io.q.out 003457bf14
ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_llap_io.q.out fcbd8e8649
ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table.q.out 17ee442da0
ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table_llap_io.q.out 5aba880938
ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part.q.out fed044e0cc
ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive.q.out 5c496953ac
ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive_llap_io.q.out eceff3bf66
ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_llap_io.q.out 36b53e5ec2
ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table.q.out ed7a0b6cc4
ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table_llap_io.q.out 867e13406b
ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part.q.out d71107d078
ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive.q.out 9d32b03dcd
ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive_llap_io.q.out 9a9f41e0c2
ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_llap_io.q.out 97a964fc60
ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table.q.out a2c26b20a6
ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table_llap_io.q.out 2c25fefee6
ql/src/test/results/clientpositive/llap/varchar_udf1.q.out fe20d54586
ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out 1846354456
ql/src/test/results/clientpositive/llap/vector_case_when_2.q.out 966f6c5a8e
ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out 2fadf29eee
ql/src/test/results/clientpositive/llap/vector_udf1.q.out aef23fd3b1
ql/src/test/results/clientpositive/llap/vector_udf2.q.out a33c6bef44
ql/src/test/results/clientpositive/llap/vector_windowing.q.out 2d49bca53b
ql/src/test/results/clientpositive/mm_buckets.q.out d37e2f6a54
ql/src/test/results/clientpositive/smb_mapjoin_20.q.out cfe1e02bf9
ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_4.q.out b5daffb9cf
ql/src/test/results/clientpositive/spark/union_remove_22.q.out 90861a3adb
ql/src/test/results/clientpositive/udf_reflect2.q.out f3bbff24d6
ql/src/test/results/clientpositive/union37.q.out 1b9ac10c0d
ql/src/test/results/clientpositive/union_remove_22.q.out 247db091ee
ql/src/test/results/clientpositive/vector_case_when_2.q.out 9ff87502af
ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out ee7602aa7a
Diff: https://reviews.apache.org/r/68011/diff/1/
Testing
-------
Thanks,
Vineet Garg
Re: Review Request 68011: HIVE-19770 Support for CBO for queries with
multiple same columns in select
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68011/#review206598
-----------------------------------------------------------
ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out
Line 115 (original), 119 (patched)
<https://reviews.apache.org/r/68011/#comment289613>
Constant propagation missed opportunity?
ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out
Line 157 (original), 161 (patched)
<https://reviews.apache.org/r/68011/#comment289614>
Constant propagation missed opportunity?
ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out
Lines 264 (patched)
<https://reviews.apache.org/r/68011/#comment289617>
This looks like a perf regression, shouldn't we be pushing this predicate through the Select to the TS?
ql/src/test/results/clientpositive/smb_mapjoin_20.q.out
Line 130 (original), 130 (patched)
<https://reviews.apache.org/r/68011/#comment289615>
Constant propagation missed opportunity?
ql/src/test/results/clientpositive/smb_mapjoin_20.q.out
Line 299 (original), 299 (patched)
<https://reviews.apache.org/r/68011/#comment289616>
Constant propagation missed opportunity?
- Jesús Camacho Rodríguez
On July 27, 2018, 11:14 p.m., Vineet Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68011/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 11:14 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.
>
>
> Bugs: HIVE-19770
> https://issues.apache.org/jira/browse/HIVE-19770
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See Jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java f008c4dfae
> ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 37c841fbd1
> ql/src/test/queries/clientpositive/masking_8.q 94e4106101
> ql/src/test/results/clientnegative/ambiguous_col.q.out a2915a4a5d
> ql/src/test/results/clientnegative/create_view_failure5.q.out d79dc64a30
> ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out 6c45fcb7ac
> ql/src/test/results/clientpositive/char_udf1.q.out 69d76d7269
> ql/src/test/results/clientpositive/keyword_2.q.out f1d63b6e5f
> ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out f707ab47be
> ql/src/test/results/clientpositive/llap/explainanalyze_2.q.out ab86821f07
> ql/src/test/results/clientpositive/llap/explainuser_2.q.out 5f5f5f6015
> ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out ebaac18127
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part.q.out 97752f3c25
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_llap_io.q.out 23c33a3141
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out eeabb8cc61
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update_llap_io.q.out f15a144a96
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table.q.out a043b679ae
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_llap_io.q.out 35c1fae6d0
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update.q.out 730d3d2312
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update_llap_io.q.out 95bfa2507d
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_llap_io.q.out 7e1cce3f4f
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update.q.out 242b95e603
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update_llap_io.q.out 53cb8fc8c4
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table.q.out 219ad7a82e
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_llap_io.q.out ce9fe84d1e
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update.q.out f8df92faf7
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update_llap_io.q.out 2292dcb24b
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part.q.out e02a1e247d
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive.q.out f70efd6f94
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive_llap_io.q.out 351d201700
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_llap_io.q.out 603c669f51
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table.q.out 454bf264d3
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table_llap_io.q.out 7ccda3dc91
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part.q.out e5aa7f418a
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive.q.out ae483ca2b0
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive_llap_io.q.out fb1a4d2d33
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table.q.out ff23f05007
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table_llap_io.q.out 97c8730c11
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part.q.out 055824ae8e
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive.q.out 29054b1e6e
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive_llap_io.q.out 003457bf14
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_llap_io.q.out 733122504a
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table.q.out 17ee442da0
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table_llap_io.q.out 5aba880938
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part.q.out a0d81b632f
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive.q.out 5c496953ac
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive_llap_io.q.out eceff3bf66
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_llap_io.q.out 36b53e5ec2
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table.q.out ed7a0b6cc4
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table_llap_io.q.out 867e13406b
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part.q.out a9db624829
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive.q.out 9d32b03dcd
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive_llap_io.q.out 9a9f41e0c2
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_llap_io.q.out 97a964fc60
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table.q.out a2c26b20a6
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table_llap_io.q.out 2c25fefee6
> ql/src/test/results/clientpositive/llap/varchar_udf1.q.out fe20d54586
> ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out 1846354456
> ql/src/test/results/clientpositive/llap/vector_case_when_2.q.out 966f6c5a8e
> ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out 2fadf29eee
> ql/src/test/results/clientpositive/llap/vector_udf1.q.out 16b5948407
> ql/src/test/results/clientpositive/llap/vector_udf2.q.out a33c6bef44
> ql/src/test/results/clientpositive/llap/vector_windowing.q.out 2d49bca53b
> ql/src/test/results/clientpositive/masking_8.q.out c4590d3422
> ql/src/test/results/clientpositive/mm_buckets.q.out d37e2f6a54
> ql/src/test/results/clientpositive/smb_mapjoin_20.q.out efaa17e659
> ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_4.q.out b5daffb9cf
> ql/src/test/results/clientpositive/spark/union_remove_22.q.out 90861a3adb
> ql/src/test/results/clientpositive/union37.q.out 1b9ac10c0d
> ql/src/test/results/clientpositive/union_remove_22.q.out 247db091ee
> ql/src/test/results/clientpositive/vector_case_when_2.q.out 9ff87502af
> ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out ee7602aa7a
>
>
> Diff: https://reviews.apache.org/r/68011/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vineet Garg
>
>
Re: Review Request 68011: HIVE-19770 Support for CBO for queries with
multiple same columns in select
Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68011/
-----------------------------------------------------------
(Updated July 27, 2018, 11:14 p.m.)
Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.
Changes
-------
Added ambiguity check
Bugs: HIVE-19770
https://issues.apache.org/jira/browse/HIVE-19770
Repository: hive-git
Description
-------
See Jira
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java f008c4dfae
ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 37c841fbd1
ql/src/test/queries/clientpositive/masking_8.q 94e4106101
ql/src/test/results/clientnegative/ambiguous_col.q.out a2915a4a5d
ql/src/test/results/clientnegative/create_view_failure5.q.out d79dc64a30
ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out 6c45fcb7ac
ql/src/test/results/clientpositive/char_udf1.q.out 69d76d7269
ql/src/test/results/clientpositive/keyword_2.q.out f1d63b6e5f
ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out f707ab47be
ql/src/test/results/clientpositive/llap/explainanalyze_2.q.out ab86821f07
ql/src/test/results/clientpositive/llap/explainuser_2.q.out 5f5f5f6015
ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out ebaac18127
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part.q.out 97752f3c25
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_llap_io.q.out 23c33a3141
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out eeabb8cc61
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update_llap_io.q.out f15a144a96
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table.q.out a043b679ae
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_llap_io.q.out 35c1fae6d0
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update.q.out 730d3d2312
ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update_llap_io.q.out 95bfa2507d
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_llap_io.q.out 7e1cce3f4f
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update.q.out 242b95e603
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update_llap_io.q.out 53cb8fc8c4
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table.q.out 219ad7a82e
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_llap_io.q.out ce9fe84d1e
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update.q.out f8df92faf7
ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update_llap_io.q.out 2292dcb24b
ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part.q.out e02a1e247d
ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive.q.out f70efd6f94
ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive_llap_io.q.out 351d201700
ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_llap_io.q.out 603c669f51
ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table.q.out 454bf264d3
ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table_llap_io.q.out 7ccda3dc91
ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part.q.out e5aa7f418a
ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive.q.out ae483ca2b0
ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive_llap_io.q.out fb1a4d2d33
ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table.q.out ff23f05007
ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table_llap_io.q.out 97c8730c11
ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part.q.out 055824ae8e
ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive.q.out 29054b1e6e
ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive_llap_io.q.out 003457bf14
ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_llap_io.q.out 733122504a
ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table.q.out 17ee442da0
ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table_llap_io.q.out 5aba880938
ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part.q.out a0d81b632f
ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive.q.out 5c496953ac
ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive_llap_io.q.out eceff3bf66
ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_llap_io.q.out 36b53e5ec2
ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table.q.out ed7a0b6cc4
ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table_llap_io.q.out 867e13406b
ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part.q.out a9db624829
ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive.q.out 9d32b03dcd
ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive_llap_io.q.out 9a9f41e0c2
ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_llap_io.q.out 97a964fc60
ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table.q.out a2c26b20a6
ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table_llap_io.q.out 2c25fefee6
ql/src/test/results/clientpositive/llap/varchar_udf1.q.out fe20d54586
ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out 1846354456
ql/src/test/results/clientpositive/llap/vector_case_when_2.q.out 966f6c5a8e
ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out 2fadf29eee
ql/src/test/results/clientpositive/llap/vector_udf1.q.out 16b5948407
ql/src/test/results/clientpositive/llap/vector_udf2.q.out a33c6bef44
ql/src/test/results/clientpositive/llap/vector_windowing.q.out 2d49bca53b
ql/src/test/results/clientpositive/masking_8.q.out c4590d3422
ql/src/test/results/clientpositive/mm_buckets.q.out d37e2f6a54
ql/src/test/results/clientpositive/smb_mapjoin_20.q.out efaa17e659
ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_4.q.out b5daffb9cf
ql/src/test/results/clientpositive/spark/union_remove_22.q.out 90861a3adb
ql/src/test/results/clientpositive/union37.q.out 1b9ac10c0d
ql/src/test/results/clientpositive/union_remove_22.q.out 247db091ee
ql/src/test/results/clientpositive/vector_case_when_2.q.out 9ff87502af
ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out ee7602aa7a
Diff: https://reviews.apache.org/r/68011/diff/2/
Changes: https://reviews.apache.org/r/68011/diff/1-2/
Testing
-------
Thanks,
Vineet Garg
Re: Review Request 68011: HIVE-19770 Support for CBO for queries with
multiple same columns in select
Posted by Vineet Garg <vg...@hortonworks.com>.
> On July 24, 2018, 11:34 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
> > Line 4070 (original), 4070 (patched)
> > <https://reviews.apache.org/r/68011/diff/1/?file=2062502#file2062502line4070>
> >
> > Looks like there is no need to duplicate() This RR can be used as is.
As far as I can tell each operator need its own Row resolver object so we shouldn't be using the object from other operator. Therefore although row resolver is same it is duplicated.
> On July 24, 2018, 11:34 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out
> > Lines 84-85 (patched)
> > <https://reviews.apache.org/r/68011/diff/1/?file=2062506#file2062506line84>
> >
> > This extra operator will result in perf loss. We do have an optimization rule to remove identity projects. Is that not able to optimize this select now?
I am not sure. This query is now going through CBO resulting in this extra select operator. I can open a jira to further investigate this.
> On July 24, 2018, 11:34 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out
> > Line 3732 (original), 3729 (patched)
> > <https://reviews.apache.org/r/68011/diff/1/?file=2062509#file2062509line3741>
> >
> > Now we are shuffling an extra constant column between vertices. This will result in perf loss.
This again is result of going through CBO. I'll open a jira to investigate this.
> On July 24, 2018, 11:34 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/vector_windowing.q.out
> > Lines 210 (patched)
> > <https://reviews.apache.org/r/68011/diff/1/?file=2062563#file2062563line210>
> >
> > Seems like RSDeDup optimization failed to merge 2 RSs in this case.
I had noticed this and had a comment about this in the jira. I plan to open a jira to investigate this.
- Vineet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68011/#review206425
-----------------------------------------------------------
On July 27, 2018, 11:14 p.m., Vineet Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68011/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 11:14 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.
>
>
> Bugs: HIVE-19770
> https://issues.apache.org/jira/browse/HIVE-19770
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See Jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java f008c4dfae
> ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 37c841fbd1
> ql/src/test/queries/clientpositive/masking_8.q 94e4106101
> ql/src/test/results/clientnegative/ambiguous_col.q.out a2915a4a5d
> ql/src/test/results/clientnegative/create_view_failure5.q.out d79dc64a30
> ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out 6c45fcb7ac
> ql/src/test/results/clientpositive/char_udf1.q.out 69d76d7269
> ql/src/test/results/clientpositive/keyword_2.q.out f1d63b6e5f
> ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out f707ab47be
> ql/src/test/results/clientpositive/llap/explainanalyze_2.q.out ab86821f07
> ql/src/test/results/clientpositive/llap/explainuser_2.q.out 5f5f5f6015
> ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out ebaac18127
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part.q.out 97752f3c25
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_llap_io.q.out 23c33a3141
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out eeabb8cc61
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update_llap_io.q.out f15a144a96
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table.q.out a043b679ae
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_llap_io.q.out 35c1fae6d0
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update.q.out 730d3d2312
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update_llap_io.q.out 95bfa2507d
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_llap_io.q.out 7e1cce3f4f
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update.q.out 242b95e603
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update_llap_io.q.out 53cb8fc8c4
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table.q.out 219ad7a82e
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_llap_io.q.out ce9fe84d1e
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update.q.out f8df92faf7
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update_llap_io.q.out 2292dcb24b
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part.q.out e02a1e247d
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive.q.out f70efd6f94
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive_llap_io.q.out 351d201700
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_llap_io.q.out 603c669f51
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table.q.out 454bf264d3
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table_llap_io.q.out 7ccda3dc91
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part.q.out e5aa7f418a
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive.q.out ae483ca2b0
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive_llap_io.q.out fb1a4d2d33
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table.q.out ff23f05007
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table_llap_io.q.out 97c8730c11
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part.q.out 055824ae8e
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive.q.out 29054b1e6e
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive_llap_io.q.out 003457bf14
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_llap_io.q.out 733122504a
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table.q.out 17ee442da0
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table_llap_io.q.out 5aba880938
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part.q.out a0d81b632f
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive.q.out 5c496953ac
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive_llap_io.q.out eceff3bf66
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_llap_io.q.out 36b53e5ec2
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table.q.out ed7a0b6cc4
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table_llap_io.q.out 867e13406b
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part.q.out a9db624829
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive.q.out 9d32b03dcd
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive_llap_io.q.out 9a9f41e0c2
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_llap_io.q.out 97a964fc60
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table.q.out a2c26b20a6
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table_llap_io.q.out 2c25fefee6
> ql/src/test/results/clientpositive/llap/varchar_udf1.q.out fe20d54586
> ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out 1846354456
> ql/src/test/results/clientpositive/llap/vector_case_when_2.q.out 966f6c5a8e
> ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out 2fadf29eee
> ql/src/test/results/clientpositive/llap/vector_udf1.q.out 16b5948407
> ql/src/test/results/clientpositive/llap/vector_udf2.q.out a33c6bef44
> ql/src/test/results/clientpositive/llap/vector_windowing.q.out 2d49bca53b
> ql/src/test/results/clientpositive/masking_8.q.out c4590d3422
> ql/src/test/results/clientpositive/mm_buckets.q.out d37e2f6a54
> ql/src/test/results/clientpositive/smb_mapjoin_20.q.out efaa17e659
> ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_4.q.out b5daffb9cf
> ql/src/test/results/clientpositive/spark/union_remove_22.q.out 90861a3adb
> ql/src/test/results/clientpositive/union37.q.out 1b9ac10c0d
> ql/src/test/results/clientpositive/union_remove_22.q.out 247db091ee
> ql/src/test/results/clientpositive/vector_case_when_2.q.out 9ff87502af
> ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out ee7602aa7a
>
>
> Diff: https://reviews.apache.org/r/68011/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vineet Garg
>
>
Re: Review Request 68011: HIVE-19770 Support for CBO for queries with
multiple same columns in select
Posted by Vineet Garg <vg...@hortonworks.com>.
> On July 24, 2018, 11:34 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out
> > Lines 84-85 (patched)
> > <https://reviews.apache.org/r/68011/diff/1/?file=2062506#file2062506line84>
> >
> > This extra operator will result in perf loss. We do have an optimization rule to remove identity projects. Is that not able to optimize this select now?
>
> Vineet Garg wrote:
> I am not sure. This query is now going through CBO resulting in this extra select operator. I can open a jira to further investigate this.
@Ashutosh - isn't this extra select operator beneficial in this case? Since now Join operator is operating on less number of columns (virtual and other columns are elimiated by select)?
> On July 24, 2018, 11:34 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out
> > Line 3732 (original), 3729 (patched)
> > <https://reviews.apache.org/r/68011/diff/1/?file=2062509#file2062509line3741>
> >
> > Now we are shuffling an extra constant column between vertices. This will result in perf loss.
>
> Vineet Garg wrote:
> This again is result of going through CBO. I'll open a jira to investigate this.
HIVE-20266
> On July 24, 2018, 11:34 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/vector_windowing.q.out
> > Lines 210 (patched)
> > <https://reviews.apache.org/r/68011/diff/1/?file=2062563#file2062563line210>
> >
> > Seems like RSDeDup optimization failed to merge 2 RSs in this case.
>
> Vineet Garg wrote:
> I had noticed this and had a comment about this in the jira. I plan to open a jira to investigate this.
HIVE-20265
- Vineet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68011/#review206425
-----------------------------------------------------------
On July 27, 2018, 11:14 p.m., Vineet Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68011/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 11:14 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.
>
>
> Bugs: HIVE-19770
> https://issues.apache.org/jira/browse/HIVE-19770
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See Jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java f008c4dfae
> ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 37c841fbd1
> ql/src/test/queries/clientpositive/masking_8.q 94e4106101
> ql/src/test/results/clientnegative/ambiguous_col.q.out a2915a4a5d
> ql/src/test/results/clientnegative/create_view_failure5.q.out d79dc64a30
> ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out 6c45fcb7ac
> ql/src/test/results/clientpositive/char_udf1.q.out 69d76d7269
> ql/src/test/results/clientpositive/keyword_2.q.out f1d63b6e5f
> ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out f707ab47be
> ql/src/test/results/clientpositive/llap/explainanalyze_2.q.out ab86821f07
> ql/src/test/results/clientpositive/llap/explainuser_2.q.out 5f5f5f6015
> ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out ebaac18127
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part.q.out 97752f3c25
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_llap_io.q.out 23c33a3141
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out eeabb8cc61
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update_llap_io.q.out f15a144a96
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table.q.out a043b679ae
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_llap_io.q.out 35c1fae6d0
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update.q.out 730d3d2312
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update_llap_io.q.out 95bfa2507d
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_llap_io.q.out 7e1cce3f4f
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update.q.out 242b95e603
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update_llap_io.q.out 53cb8fc8c4
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table.q.out 219ad7a82e
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_llap_io.q.out ce9fe84d1e
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update.q.out f8df92faf7
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update_llap_io.q.out 2292dcb24b
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part.q.out e02a1e247d
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive.q.out f70efd6f94
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive_llap_io.q.out 351d201700
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_llap_io.q.out 603c669f51
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table.q.out 454bf264d3
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table_llap_io.q.out 7ccda3dc91
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part.q.out e5aa7f418a
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive.q.out ae483ca2b0
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive_llap_io.q.out fb1a4d2d33
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table.q.out ff23f05007
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table_llap_io.q.out 97c8730c11
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part.q.out 055824ae8e
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive.q.out 29054b1e6e
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive_llap_io.q.out 003457bf14
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_llap_io.q.out 733122504a
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table.q.out 17ee442da0
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table_llap_io.q.out 5aba880938
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part.q.out a0d81b632f
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive.q.out 5c496953ac
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive_llap_io.q.out eceff3bf66
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_llap_io.q.out 36b53e5ec2
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table.q.out ed7a0b6cc4
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table_llap_io.q.out 867e13406b
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part.q.out a9db624829
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive.q.out 9d32b03dcd
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive_llap_io.q.out 9a9f41e0c2
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_llap_io.q.out 97a964fc60
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table.q.out a2c26b20a6
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table_llap_io.q.out 2c25fefee6
> ql/src/test/results/clientpositive/llap/varchar_udf1.q.out fe20d54586
> ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out 1846354456
> ql/src/test/results/clientpositive/llap/vector_case_when_2.q.out 966f6c5a8e
> ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out 2fadf29eee
> ql/src/test/results/clientpositive/llap/vector_udf1.q.out 16b5948407
> ql/src/test/results/clientpositive/llap/vector_udf2.q.out a33c6bef44
> ql/src/test/results/clientpositive/llap/vector_windowing.q.out 2d49bca53b
> ql/src/test/results/clientpositive/masking_8.q.out c4590d3422
> ql/src/test/results/clientpositive/mm_buckets.q.out d37e2f6a54
> ql/src/test/results/clientpositive/smb_mapjoin_20.q.out efaa17e659
> ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_4.q.out b5daffb9cf
> ql/src/test/results/clientpositive/spark/union_remove_22.q.out 90861a3adb
> ql/src/test/results/clientpositive/union37.q.out 1b9ac10c0d
> ql/src/test/results/clientpositive/union_remove_22.q.out 247db091ee
> ql/src/test/results/clientpositive/vector_case_when_2.q.out 9ff87502af
> ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out ee7602aa7a
>
>
> Diff: https://reviews.apache.org/r/68011/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vineet Garg
>
>
Re: Review Request 68011: HIVE-19770 Support for CBO for queries with
multiple same columns in select
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68011/#review206425
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Line 4070 (original), 4070 (patched)
<https://reviews.apache.org/r/68011/#comment289377>
Looks like there is no need to duplicate() This RR can be used as is.
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Line 4844 (original), 4836-4838 (patched)
<https://reviews.apache.org/r/68011/#comment289378>
This comment is better placed as comments for method params in genLogicalPlan()
ql/src/test/results/clientnegative/create_view_failure5.q.out
Line 1 (original), 1 (patched)
<https://reviews.apache.org/r/68011/#comment289372>
Why is clientnegative/ambiguous_col.q test removed?
ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out
Lines 84-85 (patched)
<https://reviews.apache.org/r/68011/#comment289374>
This extra operator will result in perf loss. We do have an optimization rule to remove identity projects. Is that not able to optimize this select now?
ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out
Line 3732 (original), 3729 (patched)
<https://reviews.apache.org/r/68011/#comment289375>
Now we are shuffling an extra constant column between vertices. This will result in perf loss.
ql/src/test/results/clientpositive/llap/vector_windowing.q.out
Lines 210 (patched)
<https://reviews.apache.org/r/68011/#comment289376>
Seems like RSDeDup optimization failed to merge 2 RSs in this case.
- Ashutosh Chauhan
On July 23, 2018, 1:43 a.m., Vineet Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68011/
> -----------------------------------------------------------
>
> (Updated July 23, 2018, 1:43 a.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.
>
>
> Bugs: HIVE-19770
> https://issues.apache.org/jira/browse/HIVE-19770
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See Jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java f008c4dfae
> ql/src/test/queries/clientnegative/ambiguous_col.q e8f2c8d750
> ql/src/test/results/clientnegative/ambiguous_col.q.out a2915a4a5d
> ql/src/test/results/clientnegative/create_view_failure5.q.out d79dc64a30
> ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out 6c45fcb7ac
> ql/src/test/results/clientpositive/char_udf1.q.out 69d76d7269
> ql/src/test/results/clientpositive/keyword_2.q.out f1d63b6e5f
> ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out 5e766c8982
> ql/src/test/results/clientpositive/llap/explainanalyze_2.q.out ab86821f07
> ql/src/test/results/clientpositive/llap/explainuser_2.q.out 5f5f5f6015
> ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out ebaac18127
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part.q.out 97752f3c25
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_llap_io.q.out 23c33a3141
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out eeabb8cc61
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update_llap_io.q.out f15a144a96
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table.q.out a043b679ae
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_llap_io.q.out 35c1fae6d0
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update.q.out 730d3d2312
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_table_update_llap_io.q.out 95bfa2507d
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_llap_io.q.out 7e1cce3f4f
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update.q.out 242b95e603
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_part_update_llap_io.q.out 53cb8fc8c4
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table.q.out 219ad7a82e
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_llap_io.q.out ce9fe84d1e
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update.q.out f8df92faf7
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acidvec_table_update_llap_io.q.out 2292dcb24b
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part.q.out e02a1e247d
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive.q.out f70efd6f94
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive_llap_io.q.out 351d201700
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_llap_io.q.out 603c669f51
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table.q.out 454bf264d3
> ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table_llap_io.q.out 7ccda3dc91
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part.q.out e5aa7f418a
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive.q.out ae483ca2b0
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive_llap_io.q.out fb1a4d2d33
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table.q.out ff23f05007
> ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table_llap_io.q.out 97c8730c11
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part.q.out ca2c9088a5
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive.q.out 29054b1e6e
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive_llap_io.q.out 003457bf14
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_llap_io.q.out fcbd8e8649
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table.q.out 17ee442da0
> ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table_llap_io.q.out 5aba880938
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part.q.out fed044e0cc
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive.q.out 5c496953ac
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive_llap_io.q.out eceff3bf66
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_llap_io.q.out 36b53e5ec2
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table.q.out ed7a0b6cc4
> ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table_llap_io.q.out 867e13406b
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part.q.out d71107d078
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive.q.out 9d32b03dcd
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive_llap_io.q.out 9a9f41e0c2
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_llap_io.q.out 97a964fc60
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table.q.out a2c26b20a6
> ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table_llap_io.q.out 2c25fefee6
> ql/src/test/results/clientpositive/llap/varchar_udf1.q.out fe20d54586
> ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out 1846354456
> ql/src/test/results/clientpositive/llap/vector_case_when_2.q.out 966f6c5a8e
> ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out 2fadf29eee
> ql/src/test/results/clientpositive/llap/vector_udf1.q.out aef23fd3b1
> ql/src/test/results/clientpositive/llap/vector_udf2.q.out a33c6bef44
> ql/src/test/results/clientpositive/llap/vector_windowing.q.out 2d49bca53b
> ql/src/test/results/clientpositive/mm_buckets.q.out d37e2f6a54
> ql/src/test/results/clientpositive/smb_mapjoin_20.q.out cfe1e02bf9
> ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_4.q.out b5daffb9cf
> ql/src/test/results/clientpositive/spark/union_remove_22.q.out 90861a3adb
> ql/src/test/results/clientpositive/udf_reflect2.q.out f3bbff24d6
> ql/src/test/results/clientpositive/union37.q.out 1b9ac10c0d
> ql/src/test/results/clientpositive/union_remove_22.q.out 247db091ee
> ql/src/test/results/clientpositive/vector_case_when_2.q.out 9ff87502af
> ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out ee7602aa7a
>
>
> Diff: https://reviews.apache.org/r/68011/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vineet Garg
>
>