You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2023/02/09 13:33:22 UTC
[GitHub] [superset] villebro opened a new pull request, #23051: docs(teradata): fix connection string
villebro opened a new pull request, #23051:
URL: https://github.com/apache/superset/pull/23051
### SUMMARY
This fixes the connection string for Teradata in the docs. We're recommending using [teradatasqlalchemy](https://pypi.org/project/teradatasqlalchemy/) which states you should use `teradatasql://`, not `teradata://`. See the screenshot from their README:
<img width="796" alt="image" src="https://user-images.githubusercontent.com/33317356/217826242-95c5a537-c362-44cf-83f4-ab615a2fa945.png">
It was reported that using `teradata://` ends up using `BaseEngineSpec`, which simply doesn't work: Teradata uses TOP syntax instead of LIMIT, not to mention time grains etc that will otherwise go missing.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #23051: docs(teradata): fix connection string
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #23051:
URL: https://github.com/apache/superset/pull/23051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org