[GitHub] [pulsar] Anonymitaet commented on pull request #8996: Ack response implementation

[GitBox <gi...@apache.org>]

Anonymitaet commented on PR #8996:
URL: https://github.com/apache/pulsar/pull/8996#issuecomment-1120655323

   Doc status update: I've discussed w/ @liangyepianzhou, he will add docs and @momo-jun will help review. 
   
   > @congbobo184 @codelipenghui @Anonymitaet @merlimat Has the "ackReceipt" feature added by this PR been documented? The only documentation that I can find is in the javadoc of the isAckReceiptEnabled method "Ack will return receipt but does not mean that the message will not be resent after get receipt." . Would it be possible to clarify this in the Pulsar documentation? Usually PIP documents are created for changes which change the wire protocol. I didn't find and PIP documents or mailing list discussions about this change. What problem is this change solving? The issue and PR description aren't very informative. Please elaborate more about the context behind this change.
   > 
   > Would it make sense to document this change in the "Pulsar binary protocol specification" document, https://pulsar.apache.org/docs/en/develop-binary-protocol/ https://github.com/apache/pulsar/blob/master/site2/docs/developing-binary-protocol.md ?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org