You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by dbschofield <gi...@git.apache.org> on 2017/01/30 13:43:27 UTC
[GitHub] nifi pull request #1455: NIFI-3418 Add records-per-transaction property to p...
GitHub user dbschofield opened a pull request:
https://github.com/apache/nifi/pull/1455
NIFI-3418 Add records-per-transaction property to putHiveStreaming pr\u2026
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dbschofield/nifi NIFI-3418
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1455.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1455
----
commit 440e33d35e03780112dd9ac3d45e9af8b4244c54
Author: Ben Schofield <bs...@hortonworks.com>
Date: 2017-01-30T10:44:19Z
NIFI-3418 Add records-per-transaction property to putHiveStreaming processor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1455: NIFI-3418 Add records-per-transaction property to putHiveS...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1455
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1455: NIFI-3418 Add records-per-transaction property to p...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1455#discussion_r98484332
--- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java ---
@@ -218,6 +218,16 @@
.addValidator(GREATER_THAN_ONE_VALIDATOR)
.defaultValue("100")
.build();
+
--- End diff --
This line is "empty" but has whitespace in it, causing a CheckStyle violation. I will fix while merging, so no worries. In the future you can detect such things by adding -Pcontrib-check to your Maven command.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1455: NIFI-3418 Add records-per-transaction property to p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1455
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1455: NIFI-3418 Add records-per-transaction property to putHiveS...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1455
+1 LGTM, ran full Maven build (with CheckStyle, made a minor edit) and tested on a running NiFi instance connected to a HDP Sandbox. Thank you for your contribution! Merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---