You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tgravescs <gi...@git.apache.org> on 2017/01/03 19:45:31 UTC

[GitHub] spark issue #16432: [SPARK-19021][YARN] Generailize HDFSCredentialProvider t...

Github user tgravescs commented on the issue:

    https://github.com/apache/spark/pull/16432
  
    what kind of testing have you done on this? 
    
    A couple of concerns:  
    
    1) FileSystem is kind of obscure, really I think it means hadoop filesystems.  It won't work for just any filesystem.
    
    2) this is documented: https://spark.apache.org/docs/latest/running-on-yarn.html  I'm not fond of changing config names.  Its basically an api.  However, I doubt many people are specifically setting it at this point though since its in the defaults.  Either way we would need to update that documentation. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org