You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/11/01 19:17:29 UTC

Re: Review Request 15100: Added slave retrieval in the Registrar.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15100/
-----------------------------------------------------------

(Updated Nov. 1, 2013, 6:17 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Added 'Depends On' field.


Repository: mesos-git


Description
-------

When recovering, the master needs to retrieve the set of admitted slaves from the Registrar. This adds the ability to retrieve slaves.


Diffs
-----

  src/master/registrar.hpp 5742c365bac0082efea53c35333d3c3503494066 
  src/master/registrar.cpp 42fe30ededd004e380abc835c224649e02999f11 
  src/tests/registrar_tests.cpp 51975f5aa2725f64d2a83387a381e5078c8b9e1d 

Diff: https://reviews.apache.org/r/15100/diff/


Testing
-------

Added a test.


Thanks,

Ben Mahler

Re: Review Request 15100: Added slave retrieval in the Registrar.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15100/#review28386
-----------------------------------------------------------


please attach the bug.


src/master/registrar.hpp
<https://reviews.apache.org/r/15100/#comment55209>

    Doc?



src/master/registrar.cpp
<https://reviews.apache.org/r/15100/#comment55210>

    put .then() on next line as we did everywhere else in this file.



src/tests/registrar_tests.cpp
<https://reviews.apache.org/r/15100/#comment55215>

    Do we have tests with ZK as storage?
    
    I would love if this can be a typed test that works with LevelDBStorage and ZooKeeperStorage.



src/tests/registrar_tests.cpp
<https://reviews.apache.org/r/15100/#comment55219>

    Can't you directly set value here instead of extracting the id as a temp variable which is not used anywhere else?


- Vinod Kone


On Nov. 5, 2013, 10:25 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15100/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2013, 10:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> When recovering, the master needs to retrieve the set of admitted slaves from the Registrar. This adds the ability to retrieve slaves.
> 
> 
> Diffs
> -----
> 
>   src/master/registrar.hpp 5742c365bac0082efea53c35333d3c3503494066 
>   src/master/registrar.cpp 42fe30ededd004e380abc835c224649e02999f11 
>   src/tests/registrar_tests.cpp 51975f5aa2725f64d2a83387a381e5078c8b9e1d 
> 
> Diff: https://reviews.apache.org/r/15100/diff/
> 
> 
> Testing
> -------
> 
> Added a test.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 15100: Added slave retrieval in the Registrar.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15100/
-----------------------------------------------------------

(Updated Nov. 5, 2013, 10:25 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebased.


Repository: mesos-git


Description
-------

When recovering, the master needs to retrieve the set of admitted slaves from the Registrar. This adds the ability to retrieve slaves.


Diffs (updated)
-----

  src/master/registrar.hpp 5742c365bac0082efea53c35333d3c3503494066 
  src/master/registrar.cpp 42fe30ededd004e380abc835c224649e02999f11 
  src/tests/registrar_tests.cpp 51975f5aa2725f64d2a83387a381e5078c8b9e1d 

Diff: https://reviews.apache.org/r/15100/diff/


Testing
-------

Added a test.


Thanks,

Ben Mahler