[GitHub] nifi pull request #2534: NIFI-4821

[jomach <gi...@git.apache.org>]

GitHub user jomach opened a pull request:

    https://github.com/apache/nifi/pull/2534

    NIFI-4821

      * Upgrade poi to 3.17
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jomach/nifi nifi-4821

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2534.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2534
    
----
commit d78f0e8b854f1debbd86da63c61c0d419b7e56f1
Author: Jorge Machado <jo...@...>
Date:   2018-03-12T14:46:31Z

    NIFI-4821
      * Upgrade poi to 3.17

----


---

[GitHub] nifi pull request #2534: NIFI-4821 - Upgrade to Apache POI 3.16 or newer

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2534


---

[GitHub] nifi issue #2534: NIFI-4821 - Upgrade to Apache POI 3.16 or newer

[pvillard31 <gi...@git.apache.org>]

Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/2534
  
    Checked the dependency tree using maven, looked at the differences between 3.16 and 3.17 in terms of dependencies, read the release note and change log between the two versions to ensure we're not missing anything. +1, it LGTM, merging to master. Thanks @jomach 


---

[GitHub] nifi issue #2534: NIFI-4821 - Upgrade to Apache POI 3.16 or newer

[pvillard31 <gi...@git.apache.org>]

Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/2534
  
    Not sure why this PR is not closed automatically but this has been merged in master:
    https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=b0e5e1644c17930ab3df7cc3682d62ed64b7bc1d
    
    Can you close the PR @jomach ?


---