[GitHub] [dubbo] BurningCN commented on a change in pull request #8522: Dubbo ProviderConsumerRegTable class cause OutOfMemoryException

[GitBox <gi...@apache.org>]

BurningCN commented on a change in pull request #8522:
URL: https://github.com/apache/dubbo/pull/8522#discussion_r690344076



##########
File path: dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ReferenceConfig.java
##########
@@ -423,7 +427,14 @@ private T createProxy(Map<String, String> map) {
         if (c && !invoker.isAvailable()) {
             // make it possible for consumer to retry later if provider is temporarily unavailable
             initialized = false;
-            throw new IllegalStateException("Failed to check the status of the service " + interfaceName + ". No provider available for the service " + (group == null ? "" : group + "/") + interfaceName + (version == null ? "" : ":" + version) + " from the url " + invoker.getUrl() + " to the consumer " + NetUtils.getLocalHost() + " use dubbo version " + Version.getVersion());
+            final String serviceKey = (group == null ? "" : group + "/") + interfaceName + (version == null ? "" :

Review comment:
       Here you can use `BaseServiceMetadata.buildServiceKey(path, group, version);`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org