You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/04/11 07:00:22 UTC

[GitHub] [dubbo-go-pixiu] wongoo commented on a change in pull request #150: gofumpt format

wongoo commented on a change in pull request #150:
URL: https://github.com/apache/dubbo-go-pixiu/pull/150#discussion_r611142120



##########
File path: pkg/context/base_context.go
##########
@@ -23,9 +23,10 @@ import (
 
 import (
 	"context"
-	"github.com/apache/dubbo-go-pixiu/pkg/client"
 	"math"
 	"time"
+
+	"github.com/apache/dubbo-go-pixiu/pkg/client"

Review comment:
       the format already order and split the imports with new lines, it's a hard work to split imports into diff blocks. I think we can follow the default format style of golang.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org