You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/30 20:47:27 UTC
[GitHub] [tvm] driazati opened a new pull request, #11976: [docker] Fall back to tlcpackstaging in bash.sh
driazati opened a new pull request, #11976:
URL: https://github.com/apache/tvm/pull/11976
This uses #11775 to make local builds work if they're run in the meantime before CI tags over a new image to tlcpack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron merged pull request #11976: [docker] Fall back to tlcpackstaging in bash.sh
Posted by GitBox <gi...@apache.org>.
leandron merged PR #11976:
URL: https://github.com/apache/tvm/pull/11976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #11976: [docker] Fall back to tlcpackstaging in bash.sh
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11976:
URL: https://github.com/apache/tvm/pull/11976#issuecomment-1171768893
<!---docs-bot-comment-->
Built docs for commit 02d73c2e5bd3d19f9f4ba70f9be3988d66dd826c can be found [here](https://pr-docs.tlcpack.ai/PR-11976/2/docs/index.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #11976: [docker] Fall back to tlcpackstaging in bash.sh
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #11976:
URL: https://github.com/apache/tvm/pull/11976#discussion_r911495412
##########
docker/bash.sh:
##########
@@ -290,7 +290,15 @@ DOCKER_DEVICES=( )
# If the user gave a shortcut defined in the Jenkinsfile, use it.
EXPANDED_SHORTCUT=$(lookup_image_spec "${DOCKER_IMAGE_NAME}")
if [ -n "${EXPANDED_SHORTCUT}" ]; then
- DOCKER_IMAGE_NAME="${EXPANDED_SHORTCUT}"
+ if [ "${CI}" == "true" ]; then
Review Comment:
```suggestion
if [ "${CI-}" == "true" ]; then
```
or
```suggestion
if [ "${CI+x}" == "x" ]; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #11976: [docker] Fall back to tlcpackstaging in bash.sh
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #11976:
URL: https://github.com/apache/tvm/pull/11976#discussion_r911435540
##########
docker/bash.sh:
##########
@@ -290,7 +290,11 @@ DOCKER_DEVICES=( )
# If the user gave a shortcut defined in the Jenkinsfile, use it.
EXPANDED_SHORTCUT=$(lookup_image_spec "${DOCKER_IMAGE_NAME}")
if [ -n "${EXPANDED_SHORTCUT}" ]; then
- DOCKER_IMAGE_NAME="${EXPANDED_SHORTCUT}"
+ python tests/scripts/determine_docker_images.py "$DOCKER_IMAGE_NAME=$EXPANDED_SHORTCUT" 2> /dev/null
Review Comment:
should we also check if `CI` is defined and not do this then, so that we don't double-`determine_docker_images.py` in CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org