You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@opennlp.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/10/18 14:39:00 UTC

[jira] [Commented] (OPENNLP-1387) Fix alphaNumOpt in tokenizer example

    [ https://issues.apache.org/jira/browse/OPENNLP-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619616#comment-17619616 ] 

ASF GitHub Bot commented on OPENNLP-1387:
-----------------------------------------

atarora opened a new pull request, #426:
URL: https://github.com/apache/opennlp/pull/426

   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ![Screenshot 2022-10-18 at 16 37 22](https://user-images.githubusercontent.com/5163715/196461503-ca924a44-43d6-45bf-ae1b-bc4f2d17c578.png)
   
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
   




> Fix alphaNumOpt in tokenizer example
> ------------------------------------
>
>                 Key: OPENNLP-1387
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1387
>             Project: OpenNLP
>          Issue Type: Task
>          Components: Documentation, Tokenizer
>    Affects Versions: 1.9.4, 2.0.0
>            Reporter: Jeff Zemerick
>            Priority: Major
>
> The example command for the tokenizer in the documentation is:
> {{opennlp TokenizerTrainer -model en-token.bin -alphaNumOpt -lang en -data en-token.train -encoding UTF-8}}
> This is an invalid command because the alphaNumOpt parameter must have a value. Running this command as-is will give the error "Number of parameters must be always be even." 
> The documentation for alphaNumOpt specifies it must have a value:
> {quote}
> -alphaNumOpt isAlphaNumOpt
> Optimization flag to skip alpha numeric tokens for further tokenization
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)