Re: [PR] fix(explore): stop button cancels running chart queries in the backend [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #36350:
URL: https://github.com/apache/superset/pull/36350#issuecomment-4698974976

   Thanks @X-arshiya-X, this would be a useful feature. Before this can merge, it'll need a rebase, and address the CodeAnt findings (sorry it's a noisy thread). Notably the possible `UnboundLocalError` where `query_model` is referenced unconditionally but only assigned on cache misses, rolling back the session if the best-effort commit fails, and whether client_id really needs to be in the cache key (it'll fragment the chart cache per client). Once those are sorted ping us for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org