You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/06/18 02:10:54 UTC

[GitHub] [skywalking] HackerRookie commented on pull request #4942: Multi-data source (same host:port) gets db.instance data error #4941

HackerRookie commented on pull request #4942:
URL: https://github.com/apache/skywalking/pull/4942#issuecomment-645726061


   > I am not sure your fix. Why remove old cache? This could be performance issue.
   
   1. The ConnectionCache here uses host:port to make the key, in the case of shard tables or multiple data sources (if a database instance has many database, hos and port will be the same) get the db.instance (intercepted from url) is not accurate database name .
   2. Here's just parsing url. Performance is not responsive to ignore


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org