[GitHub] hughhhh commented on a change in pull request #5106: Refactor NULL handling into method, disable for DECK.gl vizes

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #5106: Refactor NULL handling into method, disable for DECK.gl vizes
URL: https://github.com/apache/incubator-superset/pull/5106#discussion_r192253174
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -2041,6 +2044,9 @@ class BaseDeckGLViz(BaseViz):
     credits = '<a href="https://uber.github.io/deck.gl/">deck.gl</a>'
     spatial_control_keys = []
 
+    def handle_nulls(self, df):
+        pass
 
 Review comment:
   let's raise a `raise NotImplementedError()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org