You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/02 18:33:13 UTC
[GitHub] [superset] suddjian opened a new pull request #13939: chore(dashboard): Datasource -> Dataset
suddjian opened a new pull request #13939:
URL: https://github.com/apache/superset/pull/13939
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Just transitioning from deprecated terminology
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (21235ed) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.16%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.08% +0.16%
==========================================
Files 934 934
Lines 47350 47323 -27
Branches 5941 5943 +2
==========================================
+ Hits 36894 36950 +56
+ Misses 10308 10229 -79
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.58% <ø> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.66% <ø> (-0.49%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <0.00%> (-1.69%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [34 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...21235ed](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (21235ed) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.17%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.09% +0.17%
==========================================
Files 934 934
Lines 47350 47350
Branches 5941 5943 +2
==========================================
+ Hits 36894 36976 +82
+ Misses 10308 10230 -78
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.59% <ø> (ø)` | |
| presto | `?` | |
| python | `80.68% <ø> (-0.47%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-1.68%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...21235ed](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #13939:
URL: https://github.com/apache/superset/pull/13939#discussion_r606387256
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -104,17 +104,17 @@ export const FiltersConfigForm: React.FC<FiltersConfigFormProps> = ({
.map(([key]) => key);
// @ts-ignore
- const hasDatasource = !!nativeFilterItems[formFilter?.filterType]?.value
+ const hasDataset = !!nativeFilterItems[formFilter?.filterType]?.value
?.datasourceCount;
const hasColumn =
- hasDatasource &&
+ hasDataset &&
!FILTERS_WITH_ONLY_DATASOURCE.includes(formFilter?.filterType);
const hasFilledDatasource =
Review comment:
should this one be updated too?
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -271,7 +269,7 @@ export const FiltersConfigForm: React.FC<FiltersConfigFormProps> = ({
forceUpdate();
}}
filterId={filterId}
- hasDatasource={hasDatasource}
+ hasDatasource={hasDataset}
Review comment:
also this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (1378d11) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.17%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.09% +0.17%
==========================================
Files 934 934
Lines 47350 47350
Branches 5941 5941
==========================================
+ Hits 36894 36976 +82
+ Misses 10308 10230 -78
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+2.80%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.60% <ø> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <ø> (-0.47%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-1.68%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.83% <0.00%> (-0.13%)` | :arrow_down: |
| ... and [25 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...1378d11](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (21235ed) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.14%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.05% +0.14%
==========================================
Files 934 934
Lines 47350 47323 -27
Branches 5941 5943 +2
==========================================
+ Hits 36894 36940 +46
+ Misses 10308 10239 -69
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.58% <ø> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.62% <ø> (-0.53%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| ... and [36 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...21235ed](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (1378d11) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.17%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.09% +0.17%
==========================================
Files 934 934
Lines 47350 47350
Branches 5941 5941
==========================================
+ Hits 36894 36976 +82
+ Misses 10308 10230 -78
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+2.80%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.59% <ø> (ø)` | |
| presto | `?` | |
| python | `80.68% <ø> (-0.47%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-1.68%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.83% <0.00%> (-0.13%)` | :arrow_down: |
| ... and [25 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...1378d11](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (49ef771) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.12%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.04% +0.12%
==========================================
Files 934 934
Lines 47350 47323 -27
Branches 5941 5941
==========================================
+ Hits 36894 36934 +40
+ Misses 10308 10245 -63
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.60% <ø> (-0.55%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `89.53% <0.00%> (-6.98%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <0.00%> (-1.69%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| ... and [36 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...49ef771](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (a306dff) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.17%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a306dff differs from pull request most recent head 1378d11. Consider uploading reports for the commit 1378d11 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.09% +0.17%
==========================================
Files 934 934
Lines 47350 47350
Branches 5941 5941
==========================================
+ Hits 36894 36978 +84
+ Misses 10308 10228 -80
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <100.00%> (+2.83%)` | :arrow_up: |
| hive | `?` | |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-1.68%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.83% <0.00%> (-0.13%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...1378d11](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (a82c262) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.18%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a82c262 differs from pull request most recent head 21235ed. Consider uploading reports for the commit 21235ed to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.10% +0.18%
==========================================
Files 934 934
Lines 47350 47349 -1
Branches 5941 5943 +2
==========================================
+ Hits 36894 36983 +89
+ Misses 10308 10222 -86
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+2.80%)` | :arrow_up: |
| hive | `?` | |
| javascript | `66.32% <100.00%> (+0.03%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.02% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-1.68%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...21235ed](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (21235ed) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **decrease** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
- Coverage 77.91% 77.81% -0.11%
==========================================
Files 934 934
Lines 47350 47323 -27
Branches 5941 5943 +2
==========================================
- Hits 36894 36823 -71
- Misses 10308 10356 +48
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.16% <ø> (-0.99%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `25.80% <0.00%> (-32.26%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <0.00%> (-31.58%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `60.34% <0.00%> (-22.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [51 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...21235ed](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (1378d11) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **decrease** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
- Coverage 77.91% 77.81% -0.11%
==========================================
Files 934 934
Lines 47350 47323 -27
Branches 5941 5941
==========================================
- Hits 36894 36823 -71
- Misses 10308 10356 +48
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+2.80%)` | :arrow_up: |
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.16% <ø> (-0.99%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `25.80% <0.00%> (-32.26%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <0.00%> (-31.58%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `60.34% <0.00%> (-22.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `89.53% <0.00%> (-6.98%)` | :arrow_down: |
| ... and [49 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...1378d11](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (a306dff) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.17%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a306dff differs from pull request most recent head 49ef771. Consider uploading reports for the commit 49ef771 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.09% +0.17%
==========================================
Files 934 934
Lines 47350 47350
Branches 5941 5941
==========================================
+ Hits 36894 36978 +84
+ Misses 10308 10228 -80
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <100.00%> (+2.83%)` | :arrow_up: |
| hive | `?` | |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-1.68%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.83% <0.00%> (-0.13%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...49ef771](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (a82c262) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.15%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a82c262 differs from pull request most recent head 21235ed. Consider uploading reports for the commit 21235ed to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.07% +0.15%
==========================================
Files 934 935 +1
Lines 47350 47394 +44
Branches 5941 5954 +13
==========================================
+ Hits 36894 37002 +108
+ Misses 10308 10248 -60
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+2.80%)` | :arrow_up: |
| hive | `?` | |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `61.90% <ø> (ø)` | |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `85.45% <100.00%> (-7.65%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-1.68%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...21235ed](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (49ef771) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.17%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.09% +0.17%
==========================================
Files 934 934
Lines 47350 47350
Branches 5941 5941
==========================================
+ Hits 36894 36976 +82
+ Misses 10308 10230 -78
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.59% <ø> (ø)` | |
| presto | `?` | |
| python | `80.68% <ø> (-0.47%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-1.68%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.83% <0.00%> (-0.13%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...49ef771](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (1378d11) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.42%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.34% +0.42%
==========================================
Files 934 934
Lines 47350 47350
Branches 5941 5941
==========================================
+ Hits 36894 37094 +200
+ Misses 10308 10112 -196
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+2.80%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.26% <0.00%> (+0.20%)` | :arrow_up: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `98.03% <0.00%> (+1.96%)` | :arrow_up: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `99.00% <0.00%> (+2.00%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (+2.27%)` | :arrow_up: |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `85.71% <0.00%> (+3.57%)` | :arrow_up: |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+3.70%)` | :arrow_up: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <0.00%> (+3.98%)` | :arrow_up: |
| ... and [17 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...1378d11](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (a82c262) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **decrease** coverage by `0.24%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a82c262 differs from pull request most recent head 21235ed. Consider uploading reports for the commit 21235ed to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
- Coverage 77.91% 77.67% -0.25%
==========================================
Files 934 935 +1
Lines 47350 47394 +44
Branches 5941 5954 +13
==========================================
- Hits 36894 36811 -83
- Misses 10308 10426 +118
- Partials 148 157 +9
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.64% <100.00%> (+0.41%)` | :arrow_up: |
| hive | `?` | |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/dashboard/components/PublishedStatus/index.jsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy9pbmRleC5qc3g=) | `61.90% <ø> (ø)` | |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `85.45% <100.00%> (-7.65%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| ... and [40 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...21235ed](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (1378d11) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **decrease** coverage by `0.90%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
- Coverage 77.91% 77.01% -0.91%
==========================================
Files 934 934
Lines 47350 47348 -2
Branches 5941 5941
==========================================
- Hits 36894 36465 -429
- Misses 10308 10721 +413
- Partials 148 162 +14
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.65% <0.00%> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `83.90% <100.00%> (-9.20%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-59.26%)` | :arrow_down: |
| [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `44.00% <0.00%> (-56.00%)` | :arrow_down: |
| ... and [74 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...1378d11](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (1378d11) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.12%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.04% +0.12%
==========================================
Files 934 934
Lines 47350 47323 -27
Branches 5941 5941
==========================================
+ Hits 36894 36934 +40
+ Misses 10308 10245 -63
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+2.80%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.60% <ø> (-0.55%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `89.53% <0.00%> (-6.98%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <0.00%> (-1.69%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| ... and [35 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...1378d11](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (ae1166f) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.43%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head ae1166f differs from pull request most recent head 21235ed. Consider uploading reports for the commit 21235ed to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.34% +0.43%
==========================================
Files 934 934
Lines 47350 47350
Branches 5941 5942 +1
==========================================
+ Hits 36894 37098 +204
+ Misses 10308 10108 -200
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <100.00%> (+2.83%)` | :arrow_up: |
| javascript | `66.28% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.26% <0.00%> (+0.20%)` | :arrow_up: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `98.03% <0.00%> (+1.96%)` | :arrow_up: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `99.00% <0.00%> (+2.00%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (+2.27%)` | :arrow_up: |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `85.71% <0.00%> (+3.57%)` | :arrow_up: |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+3.70%)` | :arrow_up: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <0.00%> (+3.98%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...21235ed](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (ae1166f) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head ae1166f differs from pull request most recent head 49ef771. Consider uploading reports for the commit 49ef771 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
- Coverage 77.91% 77.91% -0.01%
==========================================
Files 934 934
Lines 47350 47362 +12
Branches 5941 5949 +8
==========================================
+ Hits 36894 36902 +8
- Misses 10308 10312 +4
Partials 148 148
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `66.28% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `89.89% <100.00%> (-3.21%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...49ef771](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (49ef771) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **increase** coverage by `0.17%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
+ Coverage 77.91% 78.09% +0.17%
==========================================
Files 934 934
Lines 47350 47350
Branches 5941 5941
==========================================
+ Hits 36894 36976 +82
+ Misses 10308 10230 -78
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.60% <ø> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <ø> (-0.47%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-1.68%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.83% <0.00%> (-0.13%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...49ef771](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian merged pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
suddjian merged pull request #13939:
URL: https://github.com/apache/superset/pull/13939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13939: chore(dashboard): Datasource -> Dataset
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13939:
URL: https://github.com/apache/superset/pull/13939#issuecomment-812664648
# [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=h1) Report
> Merging [#13939](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=desc) (49ef771) into [master](https://codecov.io/gh/apache/superset/commit/4187d9e4c4f3e281c3d8021010b9836cd8da12bc?el=desc) (4187d9e) will **decrease** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13939 +/- ##
==========================================
- Coverage 77.91% 77.81% -0.11%
==========================================
Files 934 934
Lines 47350 47323 -27
Branches 5941 5941
==========================================
- Hits 36894 36823 -71
- Misses 10308 10356 +48
+ Partials 148 144 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.16% <ø> (-0.99%)` | :arrow_down: |
| sqlite | `80.16% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `93.10% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `25.80% <0.00%> (-32.26%)` | :arrow_down: |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <0.00%> (-31.58%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `60.34% <0.00%> (-22.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `89.53% <0.00%> (-6.98%)` | :arrow_down: |
| ... and [50 more](https://codecov.io/gh/apache/superset/pull/13939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=footer). Last update [4187d9e...49ef771](https://codecov.io/gh/apache/superset/pull/13939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org