You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "CurtHagenlocher (via GitHub)" <gi...@apache.org> on 2023/04/08 23:09:17 UTC
[GitHub] [arrow] CurtHagenlocher opened a new pull request, #34989: GH-34988: [C#] Fix Windows-specific test issue in CDataSchemaPythonTest
CurtHagenlocher opened a new pull request, #34989:
URL: https://github.com/apache/arrow/pull/34989
### Rationale for this change
Fixes issue described in referenced bug.
### What changes are included in this PR?
Changes test initialization under Windows to add a references to the "DLLs" subdirectory containing _socket.pyd.
### Are these changes tested?
Covered by existing tests.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] CurtHagenlocher commented on pull request #34989: GH-34988: [C#] Fix Windows-specific test issue in CDataSchemaPythonTest
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #34989:
URL: https://github.com/apache/arrow/pull/34989#issuecomment-1500996144
It turned out that both my local editor and the browser-hosted GitHub editor really wanted that trailing newline in the file I was trying to revert... .
A longer description of the need for the change can be found at https://github.com/pythonnet/pythonnet/issues/2143.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on pull request #34989: GH-34988: [C#] Fix Windows-specific test issue in CDataSchemaPythonTest
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 commented on PR #34989:
URL: https://github.com/apache/arrow/pull/34989#issuecomment-1502011281
> I have to admit that I can't tell based on a cursory examination of the CI scripts how this could be working there. Is it the expectation that testing locally on dev boxes would require the use of the CI scripts?
No, it's just that, whenever possible, I'd like for our CI to be capable of catching regressions in any fixes we make. Otherwise, can't always guarantee we won't break this again.
I suppose something in find-libpython might be handling this, or else there's something in the GitHub runner's Python environment keeping it happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34989: GH-34988: [C#] Fix Windows-specific test issue in CDataSchemaPythonTest
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34989:
URL: https://github.com/apache/arrow/pull/34989#issuecomment-1500994544
:warning: GitHub issue #34988 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] CurtHagenlocher commented on pull request #34989: GH-34988: [C#] Fix Windows-specific test issue in CDataSchemaPythonTest
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #34989:
URL: https://github.com/apache/arrow/pull/34989#issuecomment-1501985420
> Thanks for submitting this @CurtHagenlocher. Could you remind me why we don't have these tests skipped or failed in Windows CI?
I have to admit that I can't tell based on a cursory examination of the CI scripts how this could be working there. Is it the expectation that testing locally on dev boxes would require the use of the CI scripts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] CurtHagenlocher commented on a diff in pull request #34989: GH-34988: [C#] Fix Windows-specific test issue in CDataSchemaPythonTest
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on code in PR #34989:
URL: https://github.com/apache/arrow/pull/34989#discussion_r1161168153
##########
csharp/src/Apache.Arrow/C/CArrowSchemaExporter.cs:
##########
@@ -86,8 +88,7 @@ public static unsafe void ExportField(Field field, CArrowSchema* schema)
{
ExportType(field.DataType, schema);
schema->name = StringUtil.ToCStringUtf8(field.Name);
- // TODO: field metadata
- schema->metadata = null;
+ schema->metadata = field.HasMetadata ? ExportMetadata(field.Metadata) : null;
Review Comment:
oops; hadn't meant to include these changes yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on pull request #34989: GH-34988: [C#] Fix Windows-specific test issue in CDataSchemaPythonTest
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 commented on PR #34989:
URL: https://github.com/apache/arrow/pull/34989#issuecomment-1501957603
Thanks for submitting this @CurtHagenlocher. Could you remind me why we don't have these tests skipped or failed in Windows CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34989: GH-34988: [C#] Fix Windows-specific test issue in CDataSchemaPythonTest
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34989:
URL: https://github.com/apache/arrow/pull/34989#issuecomment-1500994541
* Closes: #34988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34989: GH-34988: [C#] Fix Windows-specific test issue in CDataSchemaPythonTest
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34989:
URL: https://github.com/apache/arrow/pull/34989#issuecomment-1506130673
Benchmark runs are scheduled for baseline = 47a602dbd9b7b7f7720a5e62467e3e6c61712cf3 and contender = 776ea3f4f3d665f38fc370d0f284760eafa7de45. 776ea3f4f3d665f38fc370d0f284760eafa7de45 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/acecf9254bf94e91b4b87dcbea3c7766...988e270191ea4b08b5f92df9beb71e93/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/aaa4deb0e4154790a81e0f2272adacda...b48a8d0df4b245399c9327647b8b6a5f/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7e3f114189ab4b738fb75dd5fdf9bb14...050f670855544ebf924a481f4684badc/)
[Finished :arrow_down:0.12% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a93518f5d76d42e3bd5014541a55f251...b1989ce7e30040c6bf23bd3ac7f483e2/)
Buildkite builds:
[Finished] [`776ea3f4` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2682)
[Failed] [`776ea3f4` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2714)
[Finished] [`776ea3f4` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2672)
[Finished] [`776ea3f4` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2698)
[Finished] [`47a602db` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2681)
[Failed] [`47a602db` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2716)
[Finished] [`47a602db` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2680)
[Finished] [`47a602db` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2707)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] eerhardt merged pull request #34989: GH-34988: [C#] Fix Windows-specific test issue in CDataSchemaPythonTest
Posted by "eerhardt (via GitHub)" <gi...@apache.org>.
eerhardt merged PR #34989:
URL: https://github.com/apache/arrow/pull/34989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org