You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/17 02:04:03 UTC
[GitHub] [logging-log4cxx] swebb2066 opened a new pull request #103: Reference expat xml library consistenty
swebb2066 opened a new pull request #103:
URL: https://github.com/apache/logging-log4cxx/pull/103
Currently, the examples use ${XMLLIB_LIBRARIES} while tests and the log4cxx library use EXPAT::EXPAT.
This PR aims to localise in the top level CMakeLists.txt the expat library reference.
Note: find(EXPAT) will cornnect to the script shipped with the CMake modules while Find(Expat) will connect to the scripts shipped by Expat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] rm5248 commented on pull request #103: Reference expat xml library consistenty
Posted by GitBox <gi...@apache.org>.
rm5248 commented on pull request #103:
URL: https://github.com/apache/logging-log4cxx/pull/103#issuecomment-1014095458
Would it make more sense to merge this into master instead of next_stable?
Otherwise it looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] rm5248 commented on pull request #103: Reference expat xml library consistenty
Posted by GitBox <gi...@apache.org>.
rm5248 commented on pull request #103:
URL: https://github.com/apache/logging-log4cxx/pull/103#issuecomment-1014708051
looks good to me.
I prefer to merge into master and then merge master into next_stable manually once I have a few changes(so I don't have to do the same fix twice), and I think it keeps the history clean at that point, since the commits are in both branches. If you want to manually cherry-pick it that works too(no need to do a separate PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] swebb2066 commented on pull request #103: Reference expat xml library consistenty
Posted by GitBox <gi...@apache.org>.
swebb2066 commented on pull request #103:
URL: https://github.com/apache/logging-log4cxx/pull/103#issuecomment-1014152730
It occurred to me I should hande bot types of find result.
If this is OK I will cherry-pick to a master destined PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] swebb2066 edited a comment on pull request #103: Reference expat xml library consistenty
Posted by GitBox <gi...@apache.org>.
swebb2066 edited a comment on pull request #103:
URL: https://github.com/apache/logging-log4cxx/pull/103#issuecomment-1014152730
It occurred to me I should hande both types of find result.
If this is OK I will cherry-pick to a master destined PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] swebb2066 merged pull request #103: Reference expat xml library consistenty
Posted by GitBox <gi...@apache.org>.
swebb2066 merged pull request #103:
URL: https://github.com/apache/logging-log4cxx/pull/103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org