You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "renzhong (via GitHub)" <gi...@apache.org> on 2023/02/16 09:05:23 UTC
[PR] [draft]减少 lock 代码 (brpc)
renzhong opened a new pull request, #2126:
URL: https://github.com/apache/brpc/pull/2126
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响):
- Breaking backward compatibility(向后兼容性):
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] [draft]减少 lock 代码 (brpc)
Posted by "renzhong (via GitHub)" <gi...@apache.org>.
renzhong commented on PR #2126:
URL: https://github.com/apache/brpc/pull/2126#issuecomment-1434034077
> 看起来是之前c++03以及gcc3.4.5的一些兼容代码。
有个宏控制，只有开了 C++11 才会执行这部分代码，和 gcc3.4.5 可能有关系。我主要还是想请教下疑问，感觉代码区别也不大，我是不是可以关闭这个 mr 了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] [draft]减少 lock 代码 (brpc)
Posted by "chenzhangyi (via GitHub)" <gi...@apache.org>.
chenzhangyi commented on PR #2126:
URL: https://github.com/apache/brpc/pull/2126#issuecomment-1434018364
看起来是之前c++03以及gcc3.4.5的一些兼容代码。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] [draft]减少 lock 代码 (brpc)
Posted by "renzhong (via GitHub)" <gi...@apache.org>.
renzhong closed pull request #2126: [draft]减少 lock 代码
URL: https://github.com/apache/brpc/pull/2126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] [draft]减少 lock 代码 (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2126:
URL: https://github.com/apache/brpc/pull/2126#issuecomment-1433980592
PR看起来没问题，但是不明白为什么原来要那么写
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] [draft]减少 lock 代码 (brpc)
Posted by "renzhong (via GitHub)" <gi...@apache.org>.
renzhong commented on PR #2126:
URL: https://github.com/apache/brpc/pull/2126#issuecomment-1432884818
整理了代码格式，chekc 有些没有过，看错误是网络原因，这个能 rerun 么？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org