You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/28 22:25:11 UTC
[GitHub] leakingoxide opened a new pull request #6461: Add copy to clipboard
buttons in explore and sqllab
leakingoxide opened a new pull request #6461: Add copy to clipboard buttons in explore and sqllab
URL: https://github.com/apache/incubator-superset/pull/6461
This is a second attempt at https://github.com/apache/incubator-superset/issues/6064.
I've decided that if we want to display the copy to clipboard button in the View results modal, then my component is not needed because the data is already available there. Therefore I think https://github.com/apache/incubator-superset/pull/6452 should be closed, but I'll refrain from doing so till I get a review on this one.
Not sure if we'd like to create another component, e.g. `CopyToClipboardTabularData` to avoid duplication of `prepareCopyToClipboardData`.
Preview:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org