You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/03 15:32:22 UTC
[GitHub] [incubator-shardingsphere] kekerzzZ opened a new pull request
#5071: format start scaling job demo of sharding scaling
kekerzzZ opened a new pull request #5071: format start scaling job demo of sharding scaling
URL: https://github.com/apache/incubator-shardingsphere/pull/5071
format start scaling job demo of sharding scaling on the official website.
[official website](https://shardingsphere.apache.org/document/current/en/quick-start/sharding-scaling-quick-start/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kekerzzZ closed pull request #5071:
format start scaling job demo of sharding scaling
Posted by GitBox <gi...@apache.org>.
kekerzzZ closed pull request #5071: format start scaling job demo of sharding scaling
URL: https://github.com/apache/incubator-shardingsphere/pull/5071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5071:
format start scaling job demo of sharding scaling
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5071: format start scaling job demo of sharding scaling
URL: https://github.com/apache/incubator-shardingsphere/pull/5071#issuecomment-608522689
## Pull Request Test Coverage Report for [Build 10831](https://coveralls.io/builds/29828108)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.167%**
---
| Totals | [![Coverage Status](https://coveralls.io/builds/29828108/badge)](https://coveralls.io/builds/29828108) |
| :-- | --: |
| Change from base [Build 10828](https://coveralls.io/builds/29822617): | 0.0% |
| Covered Lines: | 11706 |
| Relevant Lines: | 20477 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kekerzzZ commented on issue #5071:
format start scaling job demo of sharding scaling
Posted by GitBox <gi...@apache.org>.
kekerzzZ commented on issue #5071: format start scaling job demo of sharding scaling
URL: https://github.com/apache/incubator-shardingsphere/pull/5071#issuecomment-608955139
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in
pull request #5071: format start scaling job demo of sharding scaling
Posted by GitBox <gi...@apache.org>.
KomachiSion commented on a change in pull request #5071: format start scaling job demo of sharding scaling
URL: https://github.com/apache/incubator-shardingsphere/pull/5071#discussion_r403406402
##########
File path: docs/document/content/quick-start/sharding-scaling-quick-start.cn.md
##########
@@ -53,8 +53,47 @@ curl -X POST \
-H 'content-type: application/json' \
-d '{
"ruleConfiguration": {
- "sourceDatasource": "ds_0: !!YamlDataSourceConfiguration\n dataSourceClassName: com.zaxxer.hikari.HikariDataSource\n properties:\n jdbcUrl: jdbc:mysql://127.0.0.1:3306/test?serverTimezone=UTC&useSSL=false\n username: root\n password: '\''123456'\''\n connectionTimeout: 30000\n idleTimeout: 60000\n maxLifetime: 1800000\n maxPoolSize: 50\n minPoolSize: 1\n maintenanceIntervalMilliseconds: 30000\n readOnly: false\n",
- "sourceRule": "defaultDatabaseStrategy:\n inline:\n algorithmExpression: ds_${user_id % 2}\n shardingColumn: user_id\ntables:\n t1:\n actualDataNodes: ds_0.t1\n keyGenerator:\n column: order_id\n type: SNOWFLAKE\n logicTable: t1\n tableStrategy:\n inline:\n algorithmExpression: t1\n shardingColumn: order_id\n t2:\n actualDataNodes: ds_0.t2\n keyGenerator:\n column: order_item_id\n type: SNOWFLAKE\n logicTable: t2\n tableStrategy:\n inline:\n algorithmExpression: t2\n shardingColumn: order_id\n",
+ "sourceDatasource":
+ "ds_0:
+ !!YamlDataSourceConfiguration\n
Review comment:
YAML requires strict indentation. Modification like this will cause indentation errors so that cannot be resolved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services