You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ju...@apache.org on 2014/04/04 12:43:46 UTC
svn commit: r1584610 - in /subversion/trunk/subversion:
include/private/svn_ra_svn_private.h libsvn_ra_svn/marshal.c
Author: julianfoad
Date: Fri Apr 4 10:43:46 2014
New Revision: 1584610
URL: http://svn.apache.org/r1584610
Log:
* subversion/include/private/svn_ra_svn_private.h,
subversion/libsvn_ra_svn/marshal.c
(svn_ra_svn__write_cmd_failure): Document that the 'err' input parameter
is not cleared, and make it 'const' to reinforce this.
Modified:
subversion/trunk/subversion/include/private/svn_ra_svn_private.h
subversion/trunk/subversion/libsvn_ra_svn/marshal.c
Modified: subversion/trunk/subversion/include/private/svn_ra_svn_private.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/private/svn_ra_svn_private.h?rev=1584610&r1=1584609&r2=1584610&view=diff
==============================================================================
--- subversion/trunk/subversion/include/private/svn_ra_svn_private.h (original)
+++ subversion/trunk/subversion/include/private/svn_ra_svn_private.h Fri Apr 4 10:43:46 2014
@@ -314,11 +314,13 @@ svn_ra_svn__write_cmd_response(svn_ra_sv
apr_pool_t *pool,
const char *fmt, ...);
-/** Write an unsuccessful command response over the network. */
+/** Write an unsuccessful command response over the network.
+ *
+ * @note This does not clear @a err. */
svn_error_t *
svn_ra_svn__write_cmd_failure(svn_ra_svn_conn_t *conn,
apr_pool_t *pool,
- svn_error_t *err);
+ const svn_error_t *err);
/**
* @}
Modified: subversion/trunk/subversion/libsvn_ra_svn/marshal.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_svn/marshal.c?rev=1584610&r1=1584609&r2=1584610&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_svn/marshal.c (original)
+++ subversion/trunk/subversion/libsvn_ra_svn/marshal.c Fri Apr 4 10:43:46 2014
@@ -2403,7 +2403,8 @@ svn_error_t *svn_ra_svn__write_cmd_respo
}
svn_error_t *svn_ra_svn__write_cmd_failure(svn_ra_svn_conn_t *conn,
- apr_pool_t *pool, svn_error_t *err)
+ apr_pool_t *pool,
+ const svn_error_t *err)
{
char buffer[128];
SVN_ERR(writebuf_write_short_string(conn, pool, "( failure ( ", 12));