You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Yury Kats <yu...@yahoo.com> on 2011/09/22 23:29:34 UTC

Replication: abortfetch is broken if replication was started by fetchindex?

If I start replication by issuing a "fetchindex" command with a "masterUrl"
parameter, it seems to me (by looking at the trunk code) that "abortfetch" command
would not do anything. It appears to be aborting only when replication is
configured with hardcoded master/slave cores.

Is this intentional? An oversight? Am I missing something in the code and
abortfetch does work in all cases?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: Replication: abortfetch is broken if replication was started by fetchindex?

Posted by Yury Kats <yu...@yahoo.com>.
Related question/issue: what about core close hook? Does it need to abort
replication if a core is being deleted while it's replicating (started by fetchhindex)?


On 9/23/2011 7:39 AM, Shalin Shekhar Mangar wrote:
> You are right Yury. It is a bug. The fix is to use tempSnapPuller.abortPull always because tempSnapPuller is always the snap puller doing the actual work. Have you opened an issue yet?
> 
> 2011/9/23 Yury Kats <yurykats@yahoo.com <ma...@yahoo.com>>
> 
>     If I start replication by issuing a "fetchindex" command with a "masterUrl"
>     parameter, it seems to me (by looking at the trunk code) that "abortfetch" command
>     would not do anything. It appears to be aborting only when replication is
>     configured with hardcoded master/slave cores.
> 
>     Is this intentional? An oversight? Am I missing something in the code and
>     abortfetch does work in all cases?
> 
>     ---------------------------------------------------------------------
>     To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org <ma...@lucene.apache.org>
>     For additional commands, e-mail: dev-help@lucene.apache.org <ma...@lucene.apache.org>
> 
> 
> 
> 
> -- 
> Regards,
> Shalin Shekhar Mangar.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: Replication: abortfetch is broken if replication was started by fetchindex?

Posted by Yury Kats <yu...@yahoo.com>.
On 9/23/2011 7:39 AM, Shalin Shekhar Mangar wrote:
> You are right Yury. It is a bug. The fix is to use tempSnapPuller.abortPull always because tempSnapPuller is always the snap puller doing the actual work. Have you opened an issue yet?

https://issues.apache.org/jira/browse/SOLR-2791

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: Replication: abortfetch is broken if replication was started by fetchindex?

Posted by Shalin Shekhar Mangar <sh...@gmail.com>.
You are right Yury. It is a bug. The fix is to use tempSnapPuller.abortPull
always because tempSnapPuller is always the snap puller doing the actual
work. Have you opened an issue yet?

2011/9/23 Yury Kats <yu...@yahoo.com>

> If I start replication by issuing a "fetchindex" command with a "masterUrl"
> parameter, it seems to me (by looking at the trunk code) that "abortfetch"
> command
> would not do anything. It appears to be aborting only when replication is
> configured with hardcoded master/slave cores.
>
> Is this intentional? An oversight? Am I missing something in the code and
> abortfetch does work in all cases?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>


-- 
Regards,
Shalin Shekhar Mangar.