You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/30 07:08:19 UTC
[GitHub] [incubator-inlong] wardlican opened a new pull request #3465: [INLONG-3450]Sort-SDK upgrade pb version to 3.x
wardlican opened a new pull request #3465:
URL: https://github.com/apache/incubator-inlong/pull/3465
[INLONG-3450]Sort-SDK upgrade pb version to 3.x
### Title Name: [INLONG-XYZ][component] Title of the pull request
where *XYZ* should be replaced by the actual issue number.
Fixes #3450
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #3465: [INLONG-3450][SDK] Sort-SDK upgrade pb version to 3.x
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #3465:
URL: https://github.com/apache/incubator-inlong/pull/3465#discussion_r838330723
##########
File path: inlong-sdk/sort-sdk/pom.xml
##########
@@ -111,6 +111,18 @@
<groupId>org.apache.inlong</groupId>
<artifactId>sdk-common</artifactId>
<version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <artifactId>protobuf-java</artifactId>
+ <groupId>com.google.protobuf</groupId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>3.19.4</version>
Review comment:
move the definition of version in the parent property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #3465: [INLONG-3450][SDK] Sort-SDK upgrade pb version to 3.x
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #3465:
URL: https://github.com/apache/incubator-inlong/pull/3465#discussion_r838328334
##########
File path: inlong-sdk/sort-sdk/pom.xml
##########
@@ -111,6 +111,18 @@
<groupId>org.apache.inlong</groupId>
<artifactId>sdk-common</artifactId>
<version>${project.version}</version>
+ <exclusions>
Review comment:
it's better to remove the PB dependency in `sdk-common`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] wardlican commented on a change in pull request #3465: [INLONG-3450][SDK] Sort-SDK upgrade pb version to 3.x
Posted by GitBox <gi...@apache.org>.
wardlican commented on a change in pull request #3465:
URL: https://github.com/apache/incubator-inlong/pull/3465#discussion_r839099104
##########
File path: inlong-sdk/sort-sdk/pom.xml
##########
@@ -111,6 +111,18 @@
<groupId>org.apache.inlong</groupId>
<artifactId>sdk-common</artifactId>
<version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <artifactId>protobuf-java</artifactId>
+ <groupId>com.google.protobuf</groupId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>3.19.4</version>
Review comment:
OK
##########
File path: inlong-sdk/sort-sdk/pom.xml
##########
@@ -111,6 +111,18 @@
<groupId>org.apache.inlong</groupId>
<artifactId>sdk-common</artifactId>
<version>${project.version}</version>
+ <exclusions>
Review comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #3465: [INLONG-3450][SDK] Sort-SDK change ack log from info to debug
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #3465:
URL: https://github.com/apache/incubator-inlong/pull/3465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org