You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/03/01 03:49:10 UTC

[GitHub] zeppelin pull request #2070: [ZEPPELIN-2155] Flaky test: NotebookTest - Note...

GitHub user prabhjyotsingh reopened a pull request:

    https://github.com/apache/zeppelin/pull/2070

    [ZEPPELIN-2155] Flaky test: NotebookTest -   NotebookTest.testPublicPrivateNewNote:11\u2026

    ### What is this PR for?
     - Just give some static name to note say "1111" so it is always the first note.
        So, this fixes `NotebookTest.testPublicPrivateNewNote:1173 expected:<2C[B7YJQ16]> but was:<2C[A45Z6X7]>`
    
     - Set ConfVars.ZEPPELIN_NOTEBOOK_PUBLIC.getVarName() to "true", just in case any test fails, this should be reset to normal
        This fixes `NotebookTest.testAuthorizationRoles:759 expected:<false> but was:<true>`
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * [https://issues.apache.org/jira/browse/ZEPPELIN-2155](https://issues.apache.org/jira/browse/ZEPPELIN-2155)
    
    ### How should this be tested?
    CI should not fail with  `NotebookTest.testPublicPrivateNewNote:1173 expected:<2C[B7YJQ16]> but was:<2C[A45Z6X7]>` and  `NotebookTest.testAuthorizationRoles:759 expected:<false> but was:<true>`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2155

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2070.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2070
    
----
commit 9a5be5beec1e4bc5117262f0c67a529559af62a6
Author: Prabhjyot Singh <pr...@gmail.com>
Date:   2017-02-26T07:41:46Z

    Flaky test: NotebookTest -   NotebookTest.testPublicPrivateNewNote:1173 expected:<2C[B7YJQ16]> but was:<2C[A45Z6X7]>

commit 0d1ebaf89d6dcc4a78003b3c60df2f7aaf40658d
Author: Prabhjyot Singh <pr...@gmail.com>
Date:   2017-02-26T11:28:43Z

    fix for   NotebookTest.testAuthorizationRoles:759 expected:<false> but was:<true>

commit 3ca9c7b0ac40cf6dac22cff568af45639b2bc982
Author: Prabhjyot Singh <pr...@gmail.com>
Date:   2017-03-01T03:23:48Z

    Merge remote-tracking branch 'origin/master' into ZEPPELIN-2155
    
    # Conflicts:
    #	zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---