You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "srowen (via GitHub)" <gi...@apache.org> on 2023/09/14 03:50:11 UTC

[GitHub] [spark] srowen commented on a diff in pull request #42919: [SPARK-45146][DOCS]Update the default value of 'spark.executor.logs.rolling.strategy'

srowen commented on code in PR #42919:
URL: https://github.com/apache/spark/pull/42919#discussion_r1325320926


##########
docs/configuration.md:
##########
@@ -694,7 +694,7 @@ Apart from these, the following properties are also available, and may be useful
 </tr>
 <tr>
   <td><code>spark.executor.logs.rolling.strategy</code></td>
-  <td>(none)</td>
+  <td>""</td>

Review Comment:
   You could write `"" (disabled)` to try to both express the default value and reaffirm what it means. But it already says the default is disabled and (none) communicates "not set to anything". I would leave it 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org