[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1356: MINIFICPP-1867 added tzdata to docker-minimal

[GitBox <gi...@apache.org>]

szaszm commented on code in PR #1356:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1356#discussion_r902921623


##########
docker/Dockerfile:
##########
@@ -175,6 +175,7 @@ RUN addgroup -g ${GID} ${USER} && adduser -u ${UID} -D -G ${USER} -g "" ${USER}
 # Copy built minifi distribution from builder
 COPY --from=build --chown=${USER}:${USER} ${MINIFI_VERSIONED_HOME} ${MINIFI_HOME}
 COPY --from=build --chown=${USER}:${USER} ${MINIFI_BASE_DIR}/docker/conf/minifi-log.properties ${MINIFI_HOME}/conf/minifi-log.properties
+RUN echo "UTC" > /etc/timezone

Review Comment:
   According to [this](https://wiki.alpinelinux.org/wiki/Setting_the_timezone), the manual method of setting the timezone is considered obsolete, and they recommend using [`setup-timezone`](https://wiki.alpinelinux.org/wiki/Alpine_setup_scripts#setup-timezone) instead.
   I'm assuming this only sets the timezone for musl libc, while linking a compiled timezone info file from /usr/share/zoneinfo to /etc/localtime only sets the timezone of glibc. Please use the `setup-timezone` utility unless you think I missed something.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org