You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by manishgupta88 <gi...@git.apache.org> on 2018/04/11 05:22:10 UTC

[GitHub] carbondata pull request #2154: [CARBONDATA-2329] Non Serializable extra info...

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2154#discussion_r180638168
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonSessionInfo.java ---
    @@ -60,11 +60,9 @@ public CarbonSessionInfo clone() throws CloneNotSupportedException {
         CarbonSessionInfo newObj = new CarbonSessionInfo();
         newObj.setSessionParams(sessionParams.clone());
         newObj.setThreadParams(threadParams.clone());
    -    Map<String, Object> nonSerializableExtraInfo = getNonSerializableExtraInfo();
    -    for (Map.Entry<String, Object> entry : nonSerializableExtraInfo.entrySet()) {
    -      nonSerializableExtraInfo.put(entry.getKey(), entry.getValue());
    +    for (Map.Entry<String, Object> entry : getNonSerializableExtraInfo().entrySet()) {
    +      newObj.nonSerializableExtraInfo.put(entry.getKey(), entry.getValue());
    --- End diff --
    
    here it should be newObj.getNonSerializableExtraInfo().put as nonSerializableExtraInfo is initialized only in the get method


---