[jira] [Comment Edited] (SOLR-13992) Refactor code to have collection name shard name in Replica,Slice

["Jan Høydahl (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014276#comment-17014276 ] 

Jan Høydahl edited comment on SOLR-13992 at 1/13/20 12:40 PM:
--------------------------------------------------------------

[~noble.paul]

This issue changes the only constructor of Slice and Replica. I had some plugin relying on these (public) classes which now breaks between 8.3 and 8.4. I know it's kind of internal classes, but my customer has a plugin which relies on them as part of parsing clusterstate.

Would be nice if when changing any Java APIs in minor releases, we provide a **deprecated** overloaded constructor with the old signature and in this the case of {{Slice}} e.g. initialize {{collection="(not provided)"}} or similar.

This may be even more important when people start writing plugins for the package system. If we continue just changing APIs like this in minor releases then package maintainers may have to update their plugins for every minor release and cannot safely specify 8.x as compatible version up-front.

Also, the new {{Slice}} constructor does not add javadoc for the new 'collection' parameter - please fix.


was (Author: janhoy):
[~noble.paul]

This issue changes the only constructor of Slice. I had some plugin relying on the (public) Slice class which now breaks. Would be nice if when changing APIs in minor releases, if you provide a **deprecated** overloaded constructor with the old signature and in this case e.g. initialize {{collection="(not provided)"}} or similar.

Also, the new constructor does not add javadoc for the new 'collection' parameter - please fix.

> Refactor code to have collection name shard name in Replica,Slice
> -----------------------------------------------------------------
>
>                 Key: SOLR-13992
>                 URL: https://issues.apache.org/jira/browse/SOLR-13992
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Major
>             Fix For: 8.4
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> * Replica should have the collection-name and shard name
> * Slice should have the collection-name



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org