[GitHub] [superset] rusackas commented on a change in pull request #17680: fix: replace datamask with key from new key value api

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #17680:
URL: https://github.com/apache/superset/pull/17680#discussion_r771727764



##########
File path: superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx
##########
@@ -21,6 +21,12 @@ import { useUrlShortener } from 'src/common/hooks/useUrlShortener';
 import copyTextToClipboard from 'src/utils/copy';
 import { t } from '@superset-ui/core';
 import { Menu } from 'src/common/components';
+import { getUrlParam } from 'src/utils/urlUtils';
+import { URL_PARAMS } from 'src/constants';
+import {
+  createFilterKey,
+  getFilterValue,
+} from '../../nativeFilters/FilterBar/keyValue';

Review comment:
       maybe use `src/...` path?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org