You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Ronny Pscheidl (Issue Comment Edited) (JIRA)" <ji...@apache.org> on 2011/10/07 16:53:30 UTC

[jira] [Issue Comment Edited] (WICKET-4019) Portlet Support 1.5

    [ https://issues.apache.org/jira/browse/WICKET-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122839#comment-13122839 ] 

Ronny Pscheidl edited comment on WICKET-4019 at 10/7/11 2:52 PM:
-----------------------------------------------------------------

Hello together,
im working with GateIn. Ajax request didn't work. I get the message: Ajax GET stopped because of precondition check, url... 

The reason is that the following part in wicket-ajax.js returns undefiened:
// The actual get request implementation
doGet: function() {
if (this.precondition()) { 

For testing i have patched ReponseState like this:

// FIX von Ronny für GateIn
							String output = new String(charOutputBuffer.getBuffer());
							output = output.replaceAll(Pattern.quote("function() {return Wicket.$("), Matcher.quoteReplacement("null /*function() {return Wicket.$("));
							output = output.replaceAll(Pattern.quote(") != null;}.bind(this));return !wcall;"), Matcher.quoteReplacement(") != null;}.bind(this)*/);return !wcall;"));

if precondition is null then precondition always return true.


Can you tell me where the right position is to fix this?

Kind Regards 
Ronny

excuse my bad english :-))



                
      was (Author: john.j.cool):
    Patch for GateIn Portal ajax request
                  
> Portlet Support 1.5
> -------------------
>
>                 Key: WICKET-4019
>                 URL: https://issues.apache.org/jira/browse/WICKET-4019
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Peter Pastrnak
>         Attachments: ResponseState.java, wicket-portlet-1.5.0.zip, wicket-portlet-1.5.1.zip, wicket-portlet-1.5.RC7.zip
>
>
> Url returned by the RequestMapper does not seem to be properly rendered, as it does not encode question mark character in the Url parameter value (I haven't checked the w3c spec, but at least Liferay Portal seems to require it to be encoded) 
> The reason is this definition in the UrlEncoder: 
>                         case QUERY : 
>                                 // to allow direct passing of URL in query 
>                                 dontNeedEncoding.set('/'); 
>                                 // to allow direct passing of URL in query 
>                                 dontNeedEncoding.set('?'); 
> Currently URL "http://host/file?param=a?b" would be encoded as "http://host/file?param=a?b", instead of "http://host/file?param=a%3Fb"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira