[GitHub] [maven-resolver] cstamas commented on a diff in pull request #200: [MRESOLVER-276][MRESOLVER-268] Post artifact resolve hook

[GitBox <gi...@apache.org>]

cstamas commented on code in PR #200:
URL: https://github.com/apache/maven-resolver/pull/200#discussion_r990982218


##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:
##########
@@ -426,6 +442,14 @@ else if ( local.getFile() != null )
             }
         }
 
+        for ( ArtifactResolverPostProcessor artifactResolverPostProcessor : artifactResolverPostProcessors.values() )
+        {
+            if ( artifactResolverPostProcessor.postProcess( session, results ) )
+            {
+                failures = true;
+            }

Review Comment:
   all the instances are getting the "results list" of resolver, there is no order defined or "result" from previous call.... all PP can do is "augment" (alter) the state of result (in list), or not, implementation specific (ie. the PP in this PR when "recording" will not alter anything, just collect the checksums of resolved artifacts, it does not affect the outcome of resolver in any way).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org