You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/09/24 19:33:49 UTC
[GitHub] [commons-statistics] arturobernalg opened a new pull request, #37: Remove redundant variable.
arturobernalg opened a new pull request, #37:
URL: https://github.com/apache/commons-statistics/pull/37
Do we really need this var?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-statistics] arturobernalg closed pull request #37: Remove redundant variable.
Posted by GitBox <gi...@apache.org>.
arturobernalg closed pull request #37: Remove redundant variable.
URL: https://github.com/apache/commons-statistics/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-statistics] codecov-commenter commented on pull request #37: Remove redundant variable.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #37:
URL: https://github.com/apache/commons-statistics/pull/37#issuecomment-1257051610
# [Codecov](https://codecov.io/gh/apache/commons-statistics/pull/37?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#37](https://codecov.io/gh/apache/commons-statistics/pull/37?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ff9326) into [master](https://codecov.io/gh/apache/commons-statistics/commit/0afdf878365fc4c11478368e02148b30fca308ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0afdf87) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #37 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 853 853
===========================================
Files 34 34
Lines 1599 1598 -1
Branches 256 256
===========================================
- Hits 1599 1598 -1
```
| [Impacted Files](https://codecov.io/gh/apache/commons-statistics/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../statistics/distribution/NakagamiDistribution.java](https://codecov.io/gh/apache/commons-statistics/pull/37/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9ucy1zdGF0aXN0aWNzLWRpc3RyaWJ1dGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY29tbW9ucy9zdGF0aXN0aWNzL2Rpc3RyaWJ1dGlvbi9OYWthZ2FtaURpc3RyaWJ1dGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-statistics] aherbert commented on pull request #37: Remove redundant variable.
Posted by GitBox <gi...@apache.org>.
aherbert commented on PR #37:
URL: https://github.com/apache/commons-statistics/pull/37#issuecomment-1257065200
The code is meant to be self-documenting. A Nakagami distribution is parameterised by mu and omega; the gamma distribution by shape and scale. You can sample from a Nakagami using a Gamma. Removing the variable does not enhance the code and will not change efficiency. Any caller who requires a sampler will be spending negligible time constructing a sampler and all the time using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org